system_tests.sh trying to remove env without existence check

Bug #1371496 reported by Alexander Charykov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
High
Alexander Charykov

Bug Description

Because of this error we have such errors in our logs:

+ dos.py erase 5.1_fuelmain.system_test.ubuntu.services_simple_system_test
Traceback (most recent call last):
  File "/home/jenkins/venv-nailgun-tests/bin/dos.py", line 22, in <module>
    Shell().execute()
  File "/home/jenkins/venv-nailgun-tests/local/lib/python2.7/site-packages/devops/shell.py", line 28, in execute
    self.commands.get(self.params.command)(self)
  File "/home/jenkins/venv-nailgun-tests/local/lib/python2.7/site-packages/devops/shell.py", line 49, in do_erase
    self.manager.environment_get(self.params.name).erase()
  File "/home/jenkins/venv-nailgun-tests/local/lib/python2.7/site-packages/devops/manager.py", line 56, in environment_get
    return Environment.objects.get(name=name)
  File "/home/jenkins/venv-nailgun-tests/local/lib/python2.7/site-packages/django/db/models/manager.py", line 151, in get
    return self.get_queryset().get(*args, **kwargs)
  File "/home/jenkins/venv-nailgun-tests/local/lib/python2.7/site-packages/django/db/models/query.py", line 310, in get
    self.model._meta.object_name)
devops.models.DoesNotExist: Environment matching query does not exist.

We need to add simple check if enviroment exists and not try to remove non-existing enviroment.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-main (master)

Fix proposed to branch: master
Review: https://review.openstack.org/122683

Changed in fuel:
status: Confirmed → In Progress
Changed in fuel:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-main (master)

Reviewed: https://review.openstack.org/122683
Committed: https://git.openstack.org/cgit/stackforge/fuel-main/commit/?id=ecc028189ca419a95643c38eec5576341760a311
Submitter: Jenkins
Branch: master

commit ecc028189ca419a95643c38eec5576341760a311
Author: Alexander Charykov <email address hidden>
Date: Fri Sep 19 13:12:56 2014 +0400

    Add additional check of existence of environment before erasing it

    Change-Id: I0f73e8e064d13b1dbacc19c7bfad6a1a0b0d80e1
    Closes-Bug: #1371496

Changed in fuel:
status: In Progress → Fix Committed
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
milestone: none → 6.0
Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.