AddWorldCityButton not aligned with certain languages

[Stefano Verzegnassi]

Some language (e.g. Italian) has different length for words "Add city", so this makes the horizontalCenter of AddWorldCityButton variable (see attached screenshot).

If confirmed, I already have a local branch on my PC with a fix for it (added anchors.horizontalCenterOffset equal to the half of the difference between paintedWidth of "City" label and paintedWidth of "Add" label).

[Nekhelesh Ramananthan (nik90)]

I was wondering who would report this. I was about to fix it :-). Nice catch though. I wonder if instead of adding a horizontalCenterOffset, you remove the row and horizontal align the add button with the page and then anchor the labels to the left and right of the add button?

[Stefano Verzegnassi (verzegnassi-stefano)]

Thus labels wouldn't be children of AbstractButton and the clickable area would be reduced.
If we extend AbstractButton to clockPage's width, we can keep the labels inside AddWorldCityButton.qml. Users will be able to tap also the labels, and the code will be clearer.

[Nekhelesh Ramananthan (nik90)]

yeah I meant something like,

Abstract Button {
   width: page.width
   height: button.height

  CircularButton {
     anchors.centerIn: parent
  }

  Label1 anchored to the left of circularbutton
  Label2 anchorred to the right of circularbutton
}

So they all remain within the AddWorldCityButton.qml file

[Nekhelesh Ramananthan (nik90)]

@Stefano, hey we will be pushing a clock app update at the end of the day. Would you be able to provide a patch for this by then? It would be nice to have this bug fix in the update.

[Stefano Verzegnassi (verzegnassi-stefano)]

@Nekhelesh, I was at the central police station to take the passport. The bugfix was on the list of things I have to do the next hour.
The MP will come soon. :)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

Fix committed into lp:ubuntu-clock-app at revision 107, scheduled for release in ubuntu-clock-app, milestone rtm