xenapi: should clean up old snapshots before creating a new one

Bug #1371072 reported by John Garbutt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
John Garbutt

Bug Description

When nova-compute gets forcably restarted, or fails, we get left over snapshots.

We have some clean up code for after nova-compute comes back up, but it would be good to clean up older snapshots, and generally try to minimize the size of the snapshot that goes to glance.

Tags: xenserver
Changed in nova:
importance: Undecided → Low
status: New → Triaged
assignee: nobody → John Garbutt (johngarbutt)
Changed in nova:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/122208
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=3f4a0e40af7705b037db1a2ccc63de94547f6dd7
Submitter: Jenkins
Branch: master

commit 3f4a0e40af7705b037db1a2ccc63de94547f6dd7
Author: John Garbutt <email address hidden>
Date: Wed Sep 17 18:13:33 2014 +0100

    XenAPI: clean up old snapshots before create new

    Before taking a new snapshot, we now inspect the VDI chain to check for
    old snapshots.

    Those old snapshots can be left behind from resize, migrates, and
    snapshots that get interrupted if you kill the nova-compute process.

    If you leave these snapshots behind, the hypervisor disk will get too
    full, as VDI chains grow much bigger than you would expect. In addition
    snapshots start to grow in size, causing issues copying the snapshot
    into storage.

    Closes-Bug: #1371072

    Change-Id: Ice3741213438c7b4a7fda1e3e0a6dd7faca0fd04

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → juno-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-rc1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.