move set_id_as_name_if_empty to the api side for rule_list, fwaas_list and policy_list

[Liyingjun]

we can move set_id_as_name_if_empty to the api loop for rule_list,firewall_list and policy_list to reduce a extra loop .
https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/firewalls/tabs.py#L61
https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/firewalls/tabs.py#L47
https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/firewalls/tabs.py#L82

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/122372

[Akihiro Motoki (amotoki)]

It is not limited to FWaaS panel. It is used in all of Neutron related panels.
I strongly suggest to clean up all of them.

In addition, simply moving set_id_as_name_if_empty() to the API layer is not a good idea and troublesome. This method actually changes the attribute "name" directly and this kind of decision should be delegated to the view layer (and the API layer should not change it implicitly). Assume a case of the detail page, If "name" is an empty, "name" should be displayed as an empty string rather than "(shortened UUID)". If the API layer does this, there is no way that the view layer controls it. This is the reason that set_id_as_name_if_empty() is called in the panel side.

My suggestion is to add name_or_id property to each firewall/policy/rule class and change the view layer (tables.py or related) to use name_or_id instead of "name". api.neutron.NeutronAPIDictWrapper already has "name_or_id" property, so what we need to do is to switch from set_id_as_name_if_empty to name_or_id.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/122372
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=403b81db29aa7e6ac64f446cccce0030f1937a9b
Submitter: Jenkins
Branch: master

commit 403b81db29aa7e6ac64f446cccce0030f1937a9b
Author: liyingjun <email address hidden>
Date: Thu Sep 18 16:54:30 2014 +0800

    Replace set_id_as_name_if_empty with name_or_id

    we can replace set_id_as_name_if_empty with name_or_id in
    in all neutron related place to reduce a extra loop call
    since set_id_as_name_if_empty is called every after *_list.

    Change-Id: I341adb3a581337790e22e049e5b72df11b462b44
    Closes-bug: #1370986