Unhandled Exception Trace in logs from taskflow when reqesting volume create with invalid (non-int or zero) size

Bug #1370773 reported by John Griffith
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Medium
John Griffith
Changed in cinder:
status: New → Triaged
status: Triaged → In Progress
importance: Undecided → Medium
assignee: nobody → John Griffith (john-griffith)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/122276

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on cinder (master)

Change abandoned by John Griffith (<email address hidden>) on branch: master
Review: https://review.openstack.org/122276
Reason: Seems hub isn't pulling in the latest somehow, abandoning and trying from a fresh clone

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/122306

Changed in cinder:
assignee: John Griffith (john-griffith) → Jay Bryant (jsbryant)
Changed in cinder:
assignee: Jay Bryant (jsbryant) → John Griffith (john-griffith)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/122306
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=7ed28d1c1eea6f6394a412b6a6634a7eb9585753
Submitter: Jenkins
Branch: master

commit 7ed28d1c1eea6f6394a412b6a6634a7eb9585753
Author: John Griffith <email address hidden>
Date: Wed Sep 17 21:16:18 2014 -0600

    Verify requested size in volume.api create

    Currently we're not checking that the input value requested
    for size on volume create is valid, but taskflow portion of
    the code expects it to be and as a result when it receives invalid
    input we litter the logs with Trace messages.

    This patch adds a check that verifies that if we pass in a
    size to create_volume in the volume.api that it is in fact
    an int or a string representation of an int.

    Worst commit ever

    Change-Id: I81bf515360eacf63e6f3cdb672ec7f37001aa4fb
    Closes-Bug: 1370773

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → juno-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: juno-rc1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.