DB migrations can go unchecked

Bug #1370536 reported by Dan Smith
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Dan Smith

Bug Description

Currently DB migrations can be added to the tree without the corresponding migration tests. This is bad and means that we have some that are untested in the tree already.

Tags: db
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/122162

Changed in nova:
status: Confirmed → In Progress
Revision history for this message
John Garbutt (johngarbutt) wrote :

removing from rc1 as I don't think this is a blocker.

Changed in nova:
milestone: juno-rc1 → none
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/122162
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=e87b2743377a57afd72e31b6aec879917acc8b45
Submitter: Jenkins
Branch: master

commit e87b2743377a57afd72e31b6aec879917acc8b45
Author: Dan Smith <email address hidden>
Date: Wed Sep 17 07:12:17 2014 -0700

    Require tests for DB migrations

    This patch makes it mandatory to have at least a check routine for each migration.
    Some migrations are special (like the compressed one at the beginning, and the
    placeholder migrations), and can be skipped. Also, all baremetal migrations are
    excepted from this policy since that code is deprecated and needs to go away soon.

    Change-Id: Id8c10d5ea3d8a8864a32ea4b0f0b94657e1e9bf7
    Closes-Bug: #1370536

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → juno-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-rc1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.