Cannot update firewall rule protocol to ANY

Bug #1370485 reported by Cedric Brandily
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Cedric Brandily

Bug Description

when updating a firewall rule, setting protocol to ANY is not possible ... only TCP, UDP and ICMP are available

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/122136

Changed in horizon:
assignee: nobody → Cedric Brandily (cbrandily)
status: New → In Progress
Akihiro Motoki (amotoki)
Changed in horizon:
importance: Undecided → Low
milestone: none → kilo-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by Cedric Brandily (<email address hidden>) on branch: master
Review: https://review.openstack.org/122136
Reason: Merged with https://review.openstack.org/122134

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/122134
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=ede62824b8dc6587723e2f91db05e011e0e9b35f
Submitter: Jenkins
Branch: master

commit ede62824b8dc6587723e2f91db05e011e0e9b35f
Author: Cedric Brandily <email address hidden>
Date: Wed Sep 17 14:03:18 2014 +0200

    Handle correctly protocol 'ANY' in firewall rule

    Currently horizon allows to create firewall rule with protocol == 'ANY'
    but horizon crashs if you try to update such rule because UpdateRule
    assumes that protocol is a string and fails to convert it to uppercase
    if protocol is ANY/None. Moreover horizon does not allow to update
    protocol to 'ANY' despite neutron supports it.

    This change updates UpdateRule in order to convert correctly ANY to
    None and vice versa. It allows also to update firewall rule protocol to
    ANY.

    Closes-Bug: #1324382
    Closes-Bug: #1370485
    Change-Id: I5748b8e6c1cf0ef0d7a4317016492e064b5e8918

Changed in horizon:
status: In Progress → Fix Committed
Akihiro Motoki (amotoki)
Changed in horizon:
milestone: kilo-1 → juno-rc1
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-rc1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.