Saved FTP passwords not used, password not prompted

[Bernd Eggink]

This referes to bzr-0.90.

Case 1: Let an FTP repository have the URL

    ftp://user@host/path

If this URL is used in a push command

    bzr push ftp://user@host/path # 1

the command fails with the error message:

    bzr: ERROR: Transport error: Error setting up connection: 530 Login incorrect. 530 Login incorrect.

No password prompting happens. If a colon is added to the user part

    bzr push ftp://user:@host/path

bzr prompts for the password and creates an entry in ~/.bazaar/locations.conf (if not present).
This entry, however, contains neither the password nor the colon, so the next push command (1)
fails again. Adding the colon in the locations.conf entry doesn't change this behaviour.

Case 2: The user provides a password with the URL

    bzr push ftp://user:passwd@host/path

This causes bzr to prompt for a password, although the user has just supplied one. Editing locations.conf
and adding the password to the URL doesn't change this behaviour.

The above applies to .bzr/branch/parent as well when "bzr pull" is used.

Note that in 0.18 one could insert the password manually in locations.conf and parent, and then never
had to supply the password again. This wasn't overly convenient, but at least worked.

[Vincent Ladeuil (vila)]

This a regression and will be fixed shortly (and the test suite updated).

For security reasons passwords are not stored in locations.conf nor parent files.

A spec addressing storing the passwords in a dedicated file is under work (https://blueprints.launchpad.net/bzr/+spec/authentication-ring).

[Vincent Ladeuil (vila)]

Trivial emergency patch attached.

The regression was introduced while refactoring transports for connection sharing :-/

Test suite fix in progress.