NSX plugin should set VNIC_TYPE

[Salvatore Orlando]

This nova commit: http://git.openstack.org/cgit/openstack/nova/commit/?id=a8a5d44c8aca218f00649232c2b8a46aee59b77e
made VNIC_TYPE a compulsory port bindings attribute.

This broke the NSX plugin which is now not able to boot VMs anymore. Probably other plugins are affected.
Whether VNIC_TYPE is really a required attribute questionable; the fact that port bindings is such a messy interface that can cause this kind of breakages is at least annoying.

Regardless, all plugins must now adapt.
This will also be fixed once a general fix for bug 1370077 is introduced - nevertheless, the NSX plugin can't risk staying broken for more time, and also its 3rd party integration tests are disabled because of this. For this reason we're opening a bug specific for this plugin to fast-track a fix for it.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/121907

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/121907
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=59d4c264bdcf056eb44d9d137336fde7c00f3a1b
Submitter: Jenkins
Branch: master

commit 59d4c264bdcf056eb44d9d137336fde7c00f3a1b
Author: Salvatore <email address hidden>
Date: Tue Sep 16 17:28:55 2014 +0200

    NSX plugin: set VNIC_TYPE port binding attribute

    A recent change has made this attribute required for nova
    integration.
    This patch adds this attribute to responses generated by the NSX
    plugin, and also ensures relevant unit tests are executed for the
    vmware NSX plugin.

    Change-Id: Ieebab01b406909f66a40cc683763292a9ef6f218
    Closes-Bug: #1370112