Allow right-click as a modifier

[rubenvb]

Hi,

I'm a long-time SumatraPDF user, and its mouse interface was really intuitive. The crux of the matter was: left-click: textual selection, right-click: grab-n-pan, scrolling while right-clicking: zoom.

Currently it is impossible to navigate a pdf document (panning and zooming) without touching the keyboard. I would like the option to assign right-click the role it has in SumatraPDF. Technically, this would mean delaying the right-click menu to a mousebuttonreleased event, and only showing it if the cursor has not been moved while the right mouse button was pressed.

Thanks for your great work, I like the application as a whole and use it in KDE daily.

[Adam Reichold (adamreichold)]

Hello,

thanks for your suggestion. It seems a reasonable function if enabled only via explicit configuration. Whether it is worth implementing however seems to depend on the technical difficulty of separating mouse press and context menu events and if this implies of completing handling this within the application instead of the toolkit.

Best regards, Adam.

[Adam Reichold (adamreichold)]

Hello again,

if have not forgotten anything, it seems like there is suprisingly little code necessary to support the right mouse button as a modifier. Left and middle mouse buttons are rather problematic for various reasons. I also chose to just ignore the right mouse buttons as a way to access the context menus via the mouse if it is used as a modifier (but you can still use the keyboard to access the context menu).
This might be not exactly what SumatraPDF does, but now you can use the mouse wheel to zoom using the right mouse button. Please test trunk revision 1690 or later and report your findings here. Thanks!

Best regards, Adam.

[rubenvb (vanboxem-ruben-deactivatedaccount)]

Thanks for the quick fix. It works as advertised :-) Minor nitpick: could the zoom region be centered on the mouse cursor? It currently picks the top left corner of the viewable area and draws its new region starting from there.

(Off-topic, I know) Any ETA on line by line text selection?

[Adam Reichold (adamreichold)]

Hello again,

Am 17.09.2014 um 09:00 schrieb rubenvb:
> Thanks for the quick fix. It works as advertised :-) Minor
> nitpick: could the zoom region be centered on the mouse cursor? It
> currently picks the top left corner of the viewable area and draws
> its new region starting from there.

we currently measure all relative page positions w.r.t. to the
top-left corner of the viewport and I am currently not planning to
invest time to change this.

> (Off-topic, I know) Any ETA on line by line text selection?

Sorry, but the only ETA is "patches welcome". Spare time is really
limited ATM.

Best regards, Adam.