NUMA topology checking will not check if instance can fit properly.

Bug #1369984 reported by Nikola Đipanov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Nikola Đipanov

Bug Description

When testing weather the instance can fit into the host topology will currently not take into account the number of cells hte instance has, and will only claim matching cells and pass an instance if the matching cells fit.

So for example a 4 NUMA cell isntance would pass the claims test on a 2 NUMA cell host, as long as the first 2 cells fit, without considering that the whole instance will not actually fit.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/121843

Changed in nova:
assignee: nobody → Nikola Đipanov (ndipanov)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/121843
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=903ebc2b71bbfafc29fb42eebbd87ce7e04605f4
Submitter: Jenkins
Branch: master

commit 903ebc2b71bbfafc29fb42eebbd87ce7e04605f4
Author: Nikola Dipanov <email address hidden>
Date: Tue Sep 16 16:08:00 2014 +0200

    Fix NUMA fit testing in claims and filter class

    This patch makes sure that the overall topology is considered when
    checking wather a NUMA instance can fit on a NUMA host, as previously we
    would only check the corresponding cells without considering the overall
    topology.

    It adds a method for checking it on the VirtNUMAHostTopology class and
    make sure it's called when checking for placement in the scheduler and
    confirming claims on compute hosts.

    We also split out the method for getting the topology from a host
    as it can be reused in the scheduler now.

    Change-Id: I038c81a5241bf1fd2ce37f7eff69f89ecedf59ef
    Closes-bug: #1369984

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-rc1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.