Agent responses may get lost

[Stan Lagun]

When deployment of environment fails with exception AgentListener.stop() is not called and thus there remains a listener for RabbitMQ response queue. Besides being a resource leak it introduces another problems: when that environment get redeployed it becomes 2 listeners on the same queue and responses from agents may be stolen by zombie listener making workflow wait forever for response (hang deployment)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/121590

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/121590
Committed: https://git.openstack.org/cgit/stackforge/murano/commit/?id=6252069be09a32959eb1e9b313e4ba17e4131db4
Submitter: Jenkins
Branch: master

commit 6252069be09a32959eb1e9b313e4ba17e4131db4
Author: Stan Lagun <email address hidden>
Date: Mon Sep 15 18:34:53 2014 +0400

    Fixes stealing of agent responses in some cases

    When deployment of environment fails with exception AgentListener.stop() is not
    called and thus there remains a listener for RabbitMQ response queue.
    Besides being a resource leak it introduces another problems: when that environment
    get redeployed it becomes 2 listeners on the same queue and responses from agents
    may be stolen by zombie listener making workflow wait forever or response
    (hang deployment)

    Change-Id: Ic4cedd323ab7b55690d095ed8addcb0dc3e335a7
    Closes-Bug: #1369589