NUMA topology _get_constraints_auto assumes flavor object

Bug #1369502 reported by Nikola Đipanov
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Nikola Đipanov

Bug Description

Resulting in AttributeError: 'dict' object has no attribute 'vcpus' if we try to start with a flavor that will result in Nova trying to decide on an automatic topology (for example providing only number of nodes with hw:numa_nodes extra_spec)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/121500

Changed in nova:
assignee: nobody → Nikola Đipanov (ndipanov)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/121500
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1d91921459e0d67eb668838253dc76371dbdf553
Submitter: Jenkins
Branch: master

commit 1d91921459e0d67eb668838253dc76371dbdf553
Author: Nikola Dipanov <email address hidden>
Date: Mon Sep 15 12:29:33 2014 +0200

    NUMA _get_constraint auto assumed Flavor object

    We call this code in the API that is not converted to using objects at
    the moment, so we cannot assume attribute access for dicts.

    We also make sure that tests exercising it will fail by using dicts
    exclusively until the code is converted to objects.

    Change-Id: I6fb7104de5522c51f4706c973d8d8d8697d92b31
    Closes-bug: #1369502

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-rc1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.