Set socket options in correct way

Bug #1369418 reported by Abhishek Kekane
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Abhishek Kekane

Bug Description

Currently socket options, socket.SO_REUSEADDR and socket.SO_KEEPALIVE
are set only if SSL is enabled.
Ref: https://github.com/openstack/cinder/blob/master/cinder/wsgi.py#L209

The above socket options should be set no matter SSL is enabled or not.

This issue is introduced in patch https://review.openstack.org/#/c/106377/

Tags: ntt
Changed in cinder:
assignee: nobody → Abhishek Kekane (abhishek-kekane)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/121463

Changed in cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/121463
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=47a26f1ac41100c40b7997bc4df802fa867fbd42
Submitter: Jenkins
Branch: master

commit 47a26f1ac41100c40b7997bc4df802fa867fbd42
Author: abhishekkekane <email address hidden>
Date: Fri Sep 12 02:40:31 2014 -0700

    Set socket options in correct way

    Currently socket options, socket.SO_REUSEADDR and socket.SO_KEEPALIVE
    are set only if SSL is enabled.
    The above socket options should be set no matter SSL is enabled or not.

    Closes-Bug: #1369418

    Change-Id: Ia5f6603918bda40be9965387bf464c581449d912

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → juno-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: juno-rc1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.