"played" checkbox issues

Bug #1369196 reported by Owen Williams
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Medium
Owen Williams

Bug Description

There is definitely something wrong with the track cache and dirty tracks logic.

try:

double click a track to play. Note that "played" checkbox doesn't become checked until the UI changes in some way, like a focus change or mouse moves out of the window.

Pause the track, select another, play it. Do this 8 times.

Now go back to the first played track (it should be out of the cache) and edit a field. The play box becomes unchecked.

Revision history for this message
Owen Williams (ywwg) wrote :

The problem with the values not sticking is fixed in https://github.com/mixxxdj/mixxx/commit/ee2402bad8e0f014578126b26165f29d9eaa145f

The problem with the UI not updating when the played value is triggered is still there. (I just need to figure out how to kick the UI from setlogfeature)

Revision history for this message
Owen Williams (ywwg) wrote :

For the record -- the played checkbox status was being written to the database as the string "true" which didn't read back correctly. Bools need to be converted to ints when written to sqlite. As long as the track was in the cache or never loaded again from the db (for tag editing or playing) the checkbox appeared correct.

Changed in mixxx:
milestone: none → 1.12.0
summary: - library updates / dirty tracks bugs
+ "played" checkbox issues
Max Linke (max-linke)
Changed in mixxx:
assignee: nobody → Owen Williams (ywwg)
status: New → Fix Committed
Revision history for this message
Owen Williams (ywwg) wrote :

there is still the issue of the played box not updating when it gets set by setlogfeature, so this isn't all fixed yet

Changed in mixxx:
status: Fix Committed → Confirmed
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

I believe this to be a symptom of Bug #1392557.

RJ Skerry-Ryan (rryan)
Changed in mixxx:
importance: Undecided → Medium
Revision history for this message
Owen Williams (ywwg) wrote :

I haven't seen this in a while

Revision history for this message
Owen Williams (ywwg) wrote :

I think this was fixed with the reentrancy fixes

Changed in mixxx:
status: Confirmed → Fix Committed
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7580

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.