Don't allow user to set firewall rule with port and no protocol

[OpenStack Infra]

https://review.openstack.org/120076
commit 6f3ae396ed9a9525d4ca77fb8e9b2857fe79b568
Author: Bertrand Lallau <email address hidden>
Date: Tue Sep 9 14:56:59 2014 +0200

    Don't allow user to set firewall rule with port and no protocol

    Creating firewall rules specifying a destination port and/or a source
    port without a protocol, generates rules without src or dest port
    restriction. This was a real security issue for cloud users.

    This patch generates a 400 Bad request "Source/destination port
    requires a protocol" in case of creation/update of firewall rules
    specifying a destination port and/or a source port and without protocol.

    DocImpact
    Closes-Bug: #1365961

    Change-Id: I4a3a1d9ae7ec4b2a864b3edc83d65ef7f80cbba5

[Anne Gentle (annegentle)]

The Firewall as a service needs a WADL file describing http://docs.openstack.org/api/openstack-network/2.0/content/fwaas_ext.html

[Diane Fleming (diane-fleming)]

The firewall rules and firewall policies methods are not (yet) documented. I'll add those.

[Diane Fleming (diane-fleming)]

http://specs.openstack.org/openstack/neutron-specs/specs/api/firewall_as_a_service__fwaas_.html

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/260621

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/260621
Committed: https://git.openstack.org/cgit/openstack/api-site/commit/?id=8a44bda70d312161716b0b6cad96b5cac3009df7
Submitter: Jenkins
Branch: master

commit 8a44bda70d312161716b0b6cad96b5cac3009df7
Author: Diane Fleming <email address hidden>
Date: Tue Dec 22 10:31:54 2015 -0600

    Add FWaaS firewall policies and rules

    Change-Id: I7f76f5fca330355b745b4efc0951a160a2bb068d
    Closes-Bug: #1369066