All Day Events Bar taking up too much vertical space, even when no event is scheduled.
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu Calendar App |
Fix Released
|
Medium
|
Kill Animals |
Bug Description
http://
========== Solution (nik90) ============
I looked at an existing calendar app (Google Calendar) on the phone (Android) and noticed that they don't have a All Day Events Bar. Instead they just take the approach of showing the all days events at the top if they are present. And while swiping days there was no visible jerks/jumps in the view.
I suggest we do the same. Remove the all day event bar since most people don't even use the all day events which results in precious vertical estate being lost. Let's implement this and re-evaluate how the experience is. If it feels smooth enough, then we merge to trunk.
So it should appear like this,
[ All Day Event 1 ]
[ 00:00 ]
[ 01:00 ]
If no events, it should look like,
[ 00:00 ]
[ 01:00 ]
[ 02:00 ]
[ 03:00 ]
If there are multiple all day events then it should look like,
[ All Day Event 1 ]
[ All Day Event 2 ]
[ 00:00 ]
[ 01:00 ]
========== Solution (Akiva) ============
I have taken a different strategy,
http://
What it looks like at the moment.
Related branches
- Mihir Soni: Approve
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
-
Diff: 182 lines (+69/-75)2 files modifiedAllDayEventComponent.qml (+55/-62)
TimeLineBaseComponent.qml (+14/-13)
Changed in ubuntu-calendar-app: | |
assignee: | nobody → Akiva (akiva) |
Changed in ubuntu-calendar-app: | |
milestone: | none → rtm14 |
importance: | Undecided → Medium |
description: | updated |
Changed in ubuntu-calendar-app: | |
status: | New → Triaged |
description: | updated |
Changed in ubuntu-calendar-app: | |
status: | Fix Committed → Fix Released |
we may reduce the height of it, but hiding it in case of no events, will introduce jerks/jumps in views, when we change day or week in view, i mean scroll view sideways.