[ui] Discard change button enables deployment

[Julia Aranovich]

Steps to reproduce:

1. Deploy env with some node.
2. Add another node. [Deploy Changes button became available]
3. Click Discard changes button and confirm the action.

Expected result: Deploy Changes button became disabled cause there is no new node in the deployed env.

Actual result: Deploy Changes button continues to be active. You can start deploment.

***
This issue is caused by not updated environment 'changes' attribute. It still keeps information about deleted node changes (disks && interfaces) that is not an expected behaviour.

http://paste.openstack.org/show/E9zZIPcYnhNq1aWTvKfv/

[Aleksey Kasatkin (alekseyk-ru)]

Related bug: https://bugs.launchpad.net/fuel/+bug/1354299

[Ihor Kalnytskyi (ikalnytskyi)]

The pending changes are removed from database and the next log record confirms that:

    2014-09-15 11:08:23.115 DEBUG [7f4353fff700] (cluster) Removing pending changes in environment 1 where node_id=3

If you refresh the page you will see that the button has become inactive, so I believe the issue on UI side - you need to refresh model data in case of discarding changes.

[Julia Aranovich (jkirnosova)]

Thanks for triage!

Finally, this issue should be fixed on UI side. Cluster model should be fetched after changes were discarded.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/127436

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/127436
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=a763e5cb7b030cae6a0ce47240d3fab8287d8155
Submitter: Jenkins
Branch: master

commit a763e5cb7b030cae6a0ce47240d3fab8287d8155
Author: Julia Aranovich <email address hidden>
Date: Fri Oct 10 11:29:31 2014 +0400

    Fix for 'Discard Changes' dialog

    Closes-Bug: #1368783

    Change-Id: Idc39ca4f52a224d968f8cefe334dc1ad9974e977

[Anastasia Palkina (apalkina)]

Verified on custom ISO with Juno #20

"build_id": "2014-10-10_17-06-59", "ostf_sha": "7b2200ba90302d938841584c77ee86dd55814e6a", "build_number": "20", "auth_required": true, "api": "1.0", "nailgun_sha": "1386bdb46aaa989cf1d00e52a61d0a193acbeab9", "production": "docker", "fuelmain_sha": "6d2c7107353e17d50bd5e72846d986ab5b7c430e", "astute_sha": "65a5a0781d314bdcc090a61a599a8abf95989fc1", "feature_groups": ["mirantis"], "release": "6.0", "release_versions": {"2014.2-6.0": {"VERSION": {"build_id": "2014-10-10_17-06-59", "ostf_sha": "7b2200ba90302d938841584c77ee86dd55814e6a", "build_number": "20", "api": "1.0", "nailgun_sha": "1386bdb46aaa989cf1d00e52a61d0a193acbeab9", "production": "docker", "fuelmain_sha": "6d2c7107353e17d50bd5e72846d986ab5b7c430e", "astute_sha": "65a5a0781d314bdcc090a61a599a8abf95989fc1", "feature_groups": ["mirantis"], "release": "6.0", "fuellib_sha": "f282999b04f4ff42b8d9147c9a7ab9348da1b24b"}}}, "fuellib_sha": "f282999b04f4ff42b8d9147c9a7ab9348da1b24b"