[systest] Upgrade script returns non-zero value in 'rollback_automatically_simple_env' test

Bug #1368628 reported by Artem Panchenko
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
High
Andrey Sledzinskiy
5.1.x
Fix Released
High
Andrey Sledzinskiy
6.0.x
Fix Released
High
Andrey Sledzinskiy

Bug Description

In system test 'rollback_automatically_simple_env' we inject code with exception into the upgrade scripts, so it fails and performs automatic rollback:

https://github.com/stackforge/fuel-main/blob/master/fuelweb_test/tests/test_upgrade.py#L323

But 'run_script' method raises exception, because it expects that '0' will be returned by upgrade.sh script, so system test always fails (actually it also tries to get diagnostic snapshot, but docker containers aren't ready yet):

http://jenkins-product.srt.mirantis.net:8080/view/0_master_swarm/job/master_fuelmain.system_test.centos.upgrade_rollback/33/testReport/junit/(root)/rollback_automatically_simple_env/rollback_automatically_simple_env/

We should add an additional parameter 'exit_code' to the 'run_script' method and then in the 'rollback_automatically_simple_env' tests wait for exit code "255":

http://paste.openstack.org/show/110551/

Tags: system-tests
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-main (master)

Fix proposed to branch: master
Review: https://review.openstack.org/121468

Changed in fuel:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-main (master)

Reviewed: https://review.openstack.org/121468
Committed: https://git.openstack.org/cgit/stackforge/fuel-main/commit/?id=26069341a56242de9ed11746edd5c51e3f89faa8
Submitter: Jenkins
Branch: master

commit 26069341a56242de9ed11746edd5c51e3f89faa8
Author: asledzinskiy <email address hidden>
Date: Mon Sep 15 11:05:07 2014 +0300

    Changed value of exit code for test on rollback

    Change-Id: Ieb820b25d1d53bbaf7abf9e40251e2c375bb1ba8
    Closes-Bug: #1368628

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-main (stable/5.1)

Fix proposed to branch: stable/5.1
Review: https://review.openstack.org/121765

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-main (stable/5.1)

Reviewed: https://review.openstack.org/121765
Committed: https://git.openstack.org/cgit/stackforge/fuel-main/commit/?id=0d1b2a75e6a1028a9bf0865d9e4f699c5bbc0180
Submitter: Jenkins
Branch: stable/5.1

commit 0d1b2a75e6a1028a9bf0865d9e4f699c5bbc0180
Author: asledzinskiy <email address hidden>
Date: Mon Sep 15 11:05:07 2014 +0300

    Changed value of exit code for test on rollback

    Change-Id: Ieb820b25d1d53bbaf7abf9e40251e2c375bb1ba8
    Closes-Bug: #1368628
    (cherry picked from commit 26069341a56242de9ed11746edd5c51e3f89faa8)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.