faulty way of checking if mock wasn't called

[Jacek Świderski]

Some UT use <mock>.assert_has_calls([]) as a way to check if mock wasn't called - this doesn't work because assert_has_calls only checks if passed calls are present in mock_calls and hence it is always true regardless of whether mock was called or not. This can lead to falsely passed tests.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/120787

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/120787
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=3b0ac61dea7178e858c6dede44a13818c5162283
Submitter: Jenkins
Branch: master

commit 3b0ac61dea7178e858c6dede44a13818c5162283
Author: Jacek Swiderski <email address hidden>
Date: Thu Sep 11 15:32:18 2014 +0200

    Remove faulty .assert_has_calls([])

    Some UT use <mock>.assert_has_calls([]) as a way to check if mock
    wasn't called - this doesn't work because assert_has_calls only checks
    if passed calls are present in mock_calls and hence it is always true
    regardless of whether mock was called or not. This can lead to falsely
    passed tests.

    Change-Id: I1be5327854cc3dc2f5b3733f2bad78200cfbbfd2
    Closes-Bug: #1368234