notifications broken with ZMQ driver

Bug #1368154 reported by James Page
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
oslo.messaging
Fix Released
Undecided
qiaojian

Bug Description

The listen_for_notifications incorrectly constructs a ZmqListener with additional arguments; this causes problems in ceilometer agents which use this part of the driver.

Tags: zmq
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo.messaging (master)

Fix proposed to branch: master
Review: https://review.openstack.org/120745

Changed in oslo.messaging:
assignee: nobody → James Page (james-page)
status: New → In Progress
Revision history for this message
James Page (james-page) wrote : Re: listen_for_notifications broken with ZMQ driver

Even with the correct syntax, the underlying driver has no idea how to deal with notifications so this is general quite broken right now.

summary: - listen_for_notifications broken with ZMQ driver
+ notifications broken with ZMQ driver
Changed in oslo.messaging:
milestone: none → next-kilo
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo.messaging (master)

Reviewed: https://review.openstack.org/120745
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=4b57eeed13e050c3972e42c7f86807947405eb44
Submitter: Jenkins
Branch: master

commit 4b57eeed13e050c3972e42c7f86807947405eb44
Author: James Page <email address hidden>
Date: Thu Sep 11 12:13:30 2014 +0100

    Construct ZmqListener with correct arguments

    The ZmqListener constructor only accepts a driver as an argument.

    Drop surplus 'None' in listen_for_notifications method.

    Change-Id: I6aec91122bb9406e387728eb2a2380f2c2094595
    Closes-Bug: #1368154

Changed in oslo.messaging:
status: In Progress → Fix Committed
James Page (james-page)
Changed in oslo.messaging:
status: Fix Committed → In Progress
Mehdi Abaakouk (sileht)
Changed in oslo.messaging:
milestone: 1.5.0 → next-kilo
Mehdi Abaakouk (sileht)
Changed in oslo.messaging:
milestone: 1.5.1 → next-kilo
James Page (james-page)
Changed in oslo.messaging:
assignee: James Page (james-page) → nobody
status: In Progress → Confirmed
Changed in oslo.messaging:
milestone: next-kilo → none
qiaojian (qiaojian)
Changed in oslo.messaging:
assignee: nobody → qiaojian (qiaojian)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo.messaging (master)

Fix proposed to branch: master
Review: https://review.openstack.org/150286

Changed in oslo.messaging:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo.messaging (master)

Reviewed: https://review.openstack.org/150286
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=8380ac6e661924617c53171569c1ee44dc112cea
Submitter: Jenkins
Branch: master

commit 8380ac6e661924617c53171569c1ee44dc112cea
Author: joyce <email address hidden>
Date: Tue Jan 27 14:34:18 2015 +0800

    Fix notifications broken with ZMQ driver

    The notification message did not contain a method keyword,
    so it was ignored by consumers. Another in dispatch, the
    notification msg confilict with other method.

    Change-Id: I7c60c6f80006222d3cbe818d32288d043b55a7b8
    Closes-Bug:#1368154

Changed in oslo.messaging:
status: In Progress → Fix Committed
Mehdi Abaakouk (sileht)
Changed in oslo.messaging:
milestone: none → 1.7.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.