glance rbd store get_size uses wrong pool

Bug #1368128 reported by Zoltan Arnold Nagy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Undecided
Zoltan Arnold Nagy
Icehouse
Invalid
Undecided
Unassigned

Bug Description

the rbd store's get_size() method ignores the pool of the actual parameter and instead uses the glance pool, which breaks cross-pool image access

(one such example would be when we'd reference an rbd ephemeral disk snapshot which is in the ephemeral disk pool)

Changed in glance:
assignee: nobody → Zoltan Arnold Nagy (zoltan)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance_store (master)

Fix proposed to branch: master
Review: https://review.openstack.org/121067

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance_store (master)

Reviewed: https://review.openstack.org/121067
Committed: https://git.openstack.org/cgit/openstack/glance_store/commit/?id=ff52e926731eb795a53674a60b24d31f3aa496fc
Submitter: Jenkins
Branch: master

commit ff52e926731eb795a53674a60b24d31f3aa496fc
Author: Zoltan Arnold Nagy <email address hidden>
Date: Tue Sep 23 17:55:13 2014 +0200

    Make rbd store's pool handling more universal

    Currently we ignore the pool part of the location throughout the rbd store code.
    If there is a pool specified, use that. Otherwise we can still fall back to the
    configured pool.

    This is a required change if we want to support ephemeral disk snapshotting later on
    as in that scenario the ephemeral pool might be a different pool from images pool,
    yet we're going to need to reference the snapshot of a disk in the ephemeral pool.

    Change-Id: Ie415667a809975948c8cfb71ec63a0905995fa67
    Closes-Bug: 1368128

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
milestone: none → juno-rc1
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/125341

Thierry Carrez (ttx)
Changed in glance:
milestone: juno-rc1 → 2014.2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (stable/icehouse)

Reviewed: https://review.openstack.org/125341
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=312e93eb165d66821a9f24c66a507e63e5fda9ab
Submitter: Jenkins
Branch: stable/icehouse

commit 312e93eb165d66821a9f24c66a507e63e5fda9ab
Author: Flavio Percoco <email address hidden>
Date: Tue Sep 23 17:55:13 2014 +0200

    Make rbd store's pool handling more universal

    Currently we ignore the pool part of the location throughout the rbd store code.
    If there is a pool specified, use that. Otherwise we can still fall back to the
    configured pool.

    This is a required change if we want to support ephemeral disk snapshotting later on
    as in that scenario the ephemeral pool might be a different pool from images pool,
    yet we're going to need to reference the snapshot of a disk in the ephemeral pool.

    Change-Id: Ie415667a809975948c8cfb71ec63a0905995fa67
    Closes-Bug: 1368128

tags: added: in-stable-icehouse
Revision history for this message
Zoltan Arnold Nagy (zoltan) wrote :

as this was fixed on master, and Icehouse is very very old, I'm setting this to invalid to clear old bugs.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.