Network address field in Create Subnet form needs a *

[Bradley Jones]

1. In Project > Network > Networks, select Add Subnet on one of the networks.
2. When the Create Subnet dialog comes up, press the Next button without entering a Network Address.
3. An error message will be displayed indicating that the Network Address is required

The Network Address field should be marked with a * to indicate that it must be filled in. (The network address for a subnet is a required field if a subnet is being created)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/120742

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/120742
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=9f9b197fa077dabf5884242507f52528b99f1918
Submitter: Jenkins
Branch: master

commit 9f9b197fa077dabf5884242507f52528b99f1918
Author: Bradley Jones <email address hidden>
Date: Thu Sep 11 12:08:07 2014 +0100

    Style network address for subnet as required field

    It does this by adding the required class to the network address field when the
    checkbox is enabled.

    I have also made the checkbox behave like a switchable select so when the create
    subnet checkbox is checked all fields are visible. There are hidden when create
    subnet is unselected.

    Change-Id: Id45d5ce2a1bb55e4bcaa33df065ca2b1ccee3c7e
    Closes-bug: 1367858

[Akihiro Motoki (amotoki)]

The merged commit completely breaks the behavior on IPv6 subnet.
When IPv6 is selected, all subnet related fields are hidden.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/122941

[Akihiro Motoki (amotoki)]

Due to bug 1371901, it needs to be reworked again.
Reset the status to Confirmed.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/122941
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=927a6986106402e244a3d8f3dd37fc9478cc6d02
Submitter: Jenkins
Branch: master

commit 927a6986106402e244a3d8f3dd37fc9478cc6d02
Author: Akihiro Motoki <email address hidden>
Date: Sat Sep 20 20:08:41 2014 +0900

    Revert "Style network address for subnet as required field"

    This reverts commit 9f9b197fa077dabf5884242507f52528b99f1918.

    The reverted commit completely breaks IPv6 network creation
    workflow. In the network creation workflow, when IPv6 is selected
    in "IP version", all subnet related fields will be hidden and
    users cannot created a network with IPv6 subnet.

    Change-Id: I6c974ac4c890543166117253400cb6c827aa0fb8
    Closes-Bug: #1371901
    Related-Bug: #1367858

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/123123

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/123123
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=1763d0a7e9e67ca2bb975c0b2531cc2ebf7d1ed9
Submitter: Jenkins
Branch: master

commit 1763d0a7e9e67ca2bb975c0b2531cc2ebf7d1ed9
Author: Bradley Jones <email address hidden>
Date: Mon Sep 22 14:22:07 2014 +0100

    Style network address for subnet as required field

    It does this by adding the required class to the network address field when the
    checkbox is enabled.

    I have also made the checkbox behave like a switchable select so when the create
    subnet checkbox is checked all fields are visible. They are hidden when create
    subnet is unselected.

    When the checkbox is disabled the 'subnet details' step in the workflow is
    hidden and the workflow can finish there by clicking the create button as all
    other information is to do with subnet creation.

    Issue highlighted in bug #1371901 was caused by the select.switchable methods in
    horizon.forms.js looking at everything with class switchable instead of only
    looking at select objects with class switchable.

    Change-Id: I92d7b5eee758f0433e3fb61704ddb82f52147ad5
    Closes-bug: 1367858
    Related-bug: 1371901