agent gateway port left behind when deleting VM with FIP

[Swaminathan Vasudevan]

When a VM with FloatingIP is deleted without disassociating a FIP, the internal FIP agent gateway port on that particular compute node is not deleted.

1. Create a dvr router.
2. Attach a subnet to the router
3. Attach a Gateway to the router
4. Create a Floating IP
5. Create a VM on the above subnet
6. Associate the Floating IP to the VM's private IP.
7. Now do a port-list you will see a port with device_owner as "router:floatingip_agent_gw"
8. Delete the VM ( nova delete VM-name).
9. The port still remains.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/120885

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/120917

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/120885
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=c3326996e38cb67f8d4ba3dabd829dc6f327b666
Submitter: Jenkins
Branch: master

commit c3326996e38cb67f8d4ba3dabd829dc6f327b666
Author: rajeev <email address hidden>
Date: Thu Sep 11 12:03:00 2014 -0400

    Cleanup floatingips also on router delete

    In router remove path process_router(), processing of floating ips
    is getting skipped. This change adds processing of floating ips
    if the external gateway for the router was previously set. Since
    DVR uses FIP namespaces and agent gateway ports, this change ensures
    such ports and namespaces are removed.

    Change-Id: Ib1d8fb54adcd8aab411dced695d171376687c980
    Partial-bug: #1367588

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/120917
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=2f838556a845ca183d152c6d95c11dade9024cba
Submitter: Jenkins
Branch: master

commit 2f838556a845ca183d152c6d95c11dade9024cba
Author: Swaminathan Vasudevan <email address hidden>
Date: Thu Sep 11 12:51:14 2014 -0700

    Deletes FIP agent gw port when last VM is deleted

    This patch deletes the FIP agent gateway port in
    the plugin, when the last VM with FIP using this
    FIP agent gw port on a Compute node gets deleted.

    Closes-bug: #1367588

    Change-Id: I71a9fa48544fa4bbd08ac6d83c99e6542c818009