update/cleanup to bootstrap 3 icons

Bug #1367476 reported by Cindy Lu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Undecided
Cindy Lu

Bug Description

There are still some instances of "<i class="icon-ok"></i>" and "glyphicon glyphicon-____' for icons.

We should be using font-awesome instead.

Tags: bootstrap
Cindy Lu (clu-m)
Changed in horizon:
assignee: nobody → Cindy Lu (clu-m)
Cindy Lu (clu-m)
tags: added: bootstrap
summary: - update to bootstrap 3 icons
+ update/cleanup to bootstrap 3 icons
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/120499

Changed in horizon:
status: New → In Progress
Revision history for this message
Radomir Dopieralski (deshipu) wrote :

Please use font-awesome icons instead, if possible.

Revision history for this message
Cindy Lu (clu-m) wrote :

thx, will do. I have the latest code and tried embedding '<i class="fa fa-wifi"></i>' to test, but it didn't work...

Cindy Lu (clu-m)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/120499
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=a0edef60ff282825ef62c695473dd8b97314ba27
Submitter: Jenkins
Branch: master

commit a0edef60ff282825ef62c695473dd8b97314ba27
Author: Cindy Lu <email address hidden>
Date: Wed Dec 3 10:23:27 2014 -0800

    update/cleanup bootstrap 3 icon usage

    There are some old instances of <i class='icon-ok'></i>
    and glyphicon in the code.
    We should be using font-awesome icons instead.

    Change-Id: I5269d947716854274a9b6c27b903b01606a787d3
    Closes-Bug: #1367476

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
milestone: none → kilo-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.