Passing number and bool literals to string properties fails with Property error

[Tomas Sedovic]

This template:

    heat_template_version: 2014-10-16
    resources:
      my_server:
        type: OS::Nova::Server
        properties:
          key_name: 42
          image: fedora-20.x86_64

Fails to launch with this message:
    ERROR: Property error : my_server: key_name Value must be a string

YAML treats `42` as a number, but the `key_name` expects a string. The same behaviour occurs with true/false values and it also occurs when we put these as `default` values of `type: string` parameters.

Wrapping the values in quotes fixes the issue and is probably the recommended solution. But I have seen a few people get tripped up by this and since Heat knows to expect a string there, it should be safe to cast numbers and bools.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Peter Razumovsky (<email address hidden>) on branch: master
Review: https://review.openstack.org/122352

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/125356

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/125356
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=48214930bbec2e09569d848fa5b8759c429acd5b
Submitter: Jenkins
Branch: master

commit 48214930bbec2e09569d848fa5b8759c429acd5b
Author: Jan Provaznik <email address hidden>
Date: Wed Oct 1 15:26:45 2014 +0200

    Convert bool/int values into string for string properties

    Instead of rising an exception, boolean and integer values are
    converted into string if string is expected.

    Change-Id: I1e0014576c4df447bfa1595c530f1e24f411195d
    Closes-Bug: #1367375

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/151180

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/151180
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=b52c916da0759fb5b310ecbcce5db2608b67fdb1
Submitter: Jenkins
Branch: stable/juno

commit b52c916da0759fb5b310ecbcce5db2608b67fdb1
Author: Jan Provaznik <email address hidden>
Date: Wed Oct 1 15:26:45 2014 +0200

    Convert bool/int values into string for string properties

    Instead of rising an exception, boolean and integer values are
    converted into string if string is expected.

    Change-Id: I1e0014576c4df447bfa1595c530f1e24f411195d
    Closes-Bug: #1367375
    (cherry picked from commit 48214930bbec2e09569d848fa5b8759c429acd5b)