call to _set_instance_error_state is incorrect in do_build_and_run_instance

Bug #1367342 reported by Kenneth Burger
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Joe Cropper

Bug Description

nova/compute/manager.py in do_build_and_run_instance
Under except exception.RescheduledException as e:
...
self._set_instance_error_state(context, instance.uuid)

This should be passing instance only not instance.uuid

Kenneth Burger (burgerk)
Changed in nova:
assignee: nobody → Kenneth Burger (burgerk)
assignee: Kenneth Burger (burgerk) → nobody
Joe Cropper (jwcroppe)
Changed in nova:
assignee: nobody → Joe Cropper (jwcroppe)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/120230

Changed in nova:
status: New → In Progress
Sean Dague (sdague)
Changed in nova:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/120230
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=efe1002459145c43577b53ba03a228ecf9a78434
Submitter: Jenkins
Branch: master

commit efe1002459145c43577b53ba03a228ecf9a78434
Author: Joe Cropper <email address hidden>
Date: Tue Sep 9 16:11:19 2014 -0500

    Pass instance to set_instance_error_state vs. uuid

    Quick fix to patch one case in which instance.uuid was still being
    passed to _set_instance_error_state when retries are disabled in
    rescheduling cases. Also updated the respective test case.

    Change-Id: I24a682b926bc570d7e932ffedc664a95d41fda85
    Closes-Bug: #1367342

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → juno-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-rc1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.