Iterating over a claim fails with an error referring to a claim_id param

Bug #1367290 reported by Kurt Griffiths
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
zaqar
Fix Released
Critical
Victoria Martinez de la Cruz

Bug Description

as soon as you try to iterate over the claim to get the messages, you get an error about a claim_id param not being accepted by __init__

Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/gevent/greenlet.py", line 327, in run
    result = self._run(*self.args, **self.kwargs)
  File "/root/zaqar/zaqar/bench/consumer.py", line 67, in claim_delete
    for msg in claim:
  File "/usr/local/lib/python2.7/dist-packages/zaqarclient/queues/v1/iterator.py", line 106, in __next__
    return self._create_function(args)
  File "/usr/local/lib/python2.7/dist-packages/zaqarclient/queues/v1/message.py", line 58, in <lambda>
    return lambda args: Message(parent, **args)
TypeError: __init__() got an unexpected keyword argument 'claim_id'
<Greenlet at 0x1891c30: claim_delete([<zaqarclient.queues.v1.queues.Queue object at 0x1, <multiprocessing.queues.Queue object at 0x13db250>, 10, 300, 200, 5)> failed with TypeError

Kurt Griffiths (kgriffs)
no longer affects: python-zaqarclient/trunk
no longer affects: python-zaqarclient/juno
affects: python-zaqarclient → zaqar
Changed in zaqar:
milestone: none → juno-rc1
Revision history for this message
Victoria Martinez de la Cruz (vkmc) wrote :

This is being caused by a bug in the server. Once that fix is merged, I'll try to reproduce again.

Revision history for this message
Flavio Percoco (flaper87) wrote :

Since Ic8f1a83dbe11366bad519e6507d074202b2b37dd messages return a claim_id. This change broke backwards compatibility for claims since it didn't delete the claim_id from the messages when returning claimed messages.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to zaqar (master)

Fix proposed to branch: master
Review: https://review.openstack.org/120867

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to zaqar (master)

Reviewed: https://review.openstack.org/120867
Committed: https://git.openstack.org/cgit/openstack/zaqar/commit/?id=ab0ca7d3fec42df0b3df61273494a87ce7c5c0d3
Submitter: Jenkins
Branch: master

commit ab0ca7d3fec42df0b3df61273494a87ce7c5c0d3
Author: Victoria Martínez de la Cruz <email address hidden>
Date: Thu Sep 11 14:57:05 2014 -0300

    Removes claim_id param in v1.0

    This change fixes backwards compatibility for claims
    by formating the messages obtained from the storage.

    Change-Id: I97e82f5d5b05d51a8b9cf4dd0bafc3f9e34ad638
    Closes-Bug: #1367290

Changed in zaqar:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in zaqar:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in zaqar:
milestone: juno-rc1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.