Ilo* drivers should use only ilo credentials to maintain compatibility across releases

[Anusha]

Currently IloVirtualMediaIscsiDriver and IloVirtualMediaAgentDriver uses ipmitool for console and management interfaces.
This imposes user/operator to specify ipmi credentials along with ilo credentials (which are same) during creation of node.
So, Ilo* drivers should accept only ilo credentials and process the ipmi credentials internally by inheriting the ipmi interface in Ilo driver.

Proposing the fix for juno as it would be make the node creation compatible across releases ( juno, kilo..) , as user needs to specify only ilo credentials ( no need to bother about providing ipmi or any other credentials), even if the usage of ipmi is removed in the future for IloDriver.

eg: IloManagement(ipmitool.IPMIManagement) and copy the ipmi credentials to task object during validate call of the interface
 def validate(self, task):
       ilo_common.parse_driver_info(task.node)
       _update_ipmi_properties(task) //task.node.driver_info = ipmiinfo
       super(IloManagement, self).validate(task)

Note: Code changes for the above proposed approach are ready and tested.

[Dmitry Tantsur (divius)]

1. For K we decided to rename ilo_username etc into just username, so this problem will be gone

2. For J feature freeze is long in effect, so I don't see how this bug can be fixed right now. Though feel free to discuss with other folks on IRC.

[aeva black (tenbrae)]

I agree with Anusha -- that the iLO driver also requires the user to input ipmitool's credentials *separately* is a bug. In fact, I was about to open a new bug report for that when I found this one.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/124704

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/124704
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=c5bfba0f2f4af68f111cb7b682838ec1fe44b8c1
Submitter: Jenkins
Branch: master

commit c5bfba0f2f4af68f111cb7b682838ec1fe44b8c1
Author: Anusha Ramineni <email address hidden>
Date: Mon Sep 29 17:01:15 2014 +0530

    ilo* drivers to use only ilo credentials

    Currently IloVirtualMediaIscsiDriver and IloVirtualMediaAgentDriver
    and pxe_ilo driver uses ipmitool for console and management interfaces.
    This imposes user/operator to specify ipmi credentials along with ilo
    credentials (which are same) during creation of node.

    This fix proposes to update the ipmi credentials on the fly by inheriting
    IPMI console and Management Interface.

    Change-Id: I81c1311b05bd00bb8245ceb71a140f6bdd2e7daa
    Closes-bug:#1367182