bashisms in update_firmware

Bug #1366986 reported by Steve Langasek
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
powerpc-ibm-utils (Ubuntu)
Fix Released
Undecided
Adam Conrad
Trusty
Fix Released
Undecided
Unassigned

Bug Description

The update_flash_nv script contains a number of bashisms.

# update_flash --help
/usr/sbin/update_flash_nv: 375: [: root: unexpected operator
update_flash: Must be root to execute this command.
#

Correcting the == to = (in two places), the script then fails instead with:

# update_flash -v -f 01TV810_061_054.img
/usr/sbin/update_flash_nv: 204: local: FW810.00: bad variable name
#

This one appears to be a matter of missing quoting.

Adam Conrad (adconrad)
Changed in powerpc-ibm-utils (Ubuntu):
assignee: nobody → Adam Conrad (adconrad)
status: New → In Progress
Revision history for this message
Adam Conrad (adconrad) wrote :

Looks like this was fixed in utopic with 1.2.21, adding a trusty task so we don't forget that it needs an SRU.

Changed in powerpc-ibm-utils (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in powerpc-ibm-utils (Ubuntu Trusty):
status: New → Confirmed
Adam Conrad (adconrad)
Changed in powerpc-ibm-utils (Ubuntu Trusty):
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.