NSX: create_port should return empty list instead of null for allowed-address-pair

[Aaron Rosen]

ft133.5: tempest.api.network.test_ports.PortsTestJSON.test_show_port[gate,smoke]_StringException: pythonlogging:'': {{{2014-09-07 18:53:43,165 17979 INFO [tempest.common.rest_client] Request (PortsTestJSON:test_show_port): 200 GET http://localhost:9696/v2.0/ports/2827a27a-dee1-4013-b90f-cf2aeeae5f4f 0.030s}}}

Traceback (most recent call last):
  File "tempest/api/network/test_ports.py", line 81, in test_show_port
    (port, excluded_keys=['extra_dhcp_opts']))
  File "/opt/stack/tempest/.tox/smoke-serial/local/lib/python2.7/site-packages/testtools/testcase.py", line 433, in assertThat
    raise mismatch_error
MismatchError: Only in actual:
  {'binding:vnic_type': normal}
Differences:
  allowed_address_pairs: expected [], actual None

Traceback (most recent call last):
_StringException: Empty attachments:
  stderr
  stdout

pythonlogging:'': {{{2014-09-07 18:53:43,165 17979 INFO [tempest.common.rest_client] Request (PortsTestJSON:test_show_port): 200 GET http://localhost:9696/v2.0/ports/2827a27a-dee1-4013-b90f-cf2aeeae5f4f 0.030s}}}

Traceback (most recent call last):
  File "tempest/api/network/test_ports.py", line 81, in test_show_port
    (port, excluded_keys=['extra_dhcp_opts']))
  File "/opt/stack/tempest/.tox/smoke-serial/local/lib/python2.7/site-packages/testtools/testcase.py", line 433, in assertThat
    raise mismatch_error
MismatchError: Only in actual:
  {'binding:vnic_type': normal}
Differences:
  allowed_address_pairs: expected [], actual None

Traceback (most recent call last):
_StringException: Empty attachments:
  stderr
  stdout

pythonlogging:'': {{{2014-09-07 18:53:43,165 17979 INFO [tempest.common.rest_client] Request (PortsTestJSON:test_show_port): 200 GET http://localhost:9696/v2.0/ports/2827a27a-dee1-4013-b90f-cf2aeeae5f4f 0.030s}}}

Traceback (most recent call last):
  File "tempest/api/network/test_ports.py", line 81, in test_show_port
    (port, excluded_keys=['extra_dhcp_opts']))
  File "/opt/stack/tempest/.tox/smoke-serial/local/lib/python2.7/site-packages/testtools/testcase.py", line 433, in assertThat
    raise mismatch_error
MismatchError: Only in actual:
  {'binding:vnic_type': normal}
Differences:
  allowed_address_pairs: expected [], actual None

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/119864

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/120160

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/119864
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=1361ad99969d2a729599720f06f8373db230e0ed
Submitter: Jenkins
Branch: master

commit 1361ad99969d2a729599720f06f8373db230e0ed
Author: Aaron Rosen <email address hidden>
Date: Mon Sep 8 11:23:50 2014 -0700

    NSX: Correct allowed_address_pair return value on create_port

    This patch fixes the NSX plugin to return [] rather than None for a
    port does not have any allowed_address_pairs when a create_port api
    call is made. Currently the NSX plugin is failing every patch because
    now tempest is checking for this value to be [].

    Change-Id: Ic82c564ff62000c367c544f44a76694be9375790
    Closes-bug: 1366921

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/120160
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=255df456334a9a888f92ad22b2e53fef8492a091
Submitter: Jenkins
Branch: stable/icehouse

commit 255df456334a9a888f92ad22b2e53fef8492a091
Author: Aaron Rosen <email address hidden>
Date: Mon Sep 8 11:23:50 2014 -0700

    NSX: Correct allowed_address_pair return value on create_port

    This patch fixes the NSX plugin to return [] rather than None for a
    port does not have any allowed_address_pairs when a create_port api
    call is made. Currently the NSX plugin is failing every patch because
    now tempest is checking for this value to be [].

    Change-Id: Ic82c564ff62000c367c544f44a76694be9375790
    Closes-bug: 1366921
    (cherry picked from commit 1361ad99969d2a729599720f06f8373db230e0ed)