Handling amqp_auto_delete for a queue is inconsistent between Notifier and Listener

Bug #1366597 reported by Arata Notsu
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
oslo.messaging
Fix Released
Medium
Mehdi Abaakouk

Bug Description

In oslo/messaging/_drivers/impl_rabbit.py,

when declares a queue, Notifier uses NotifyPublisher.reconnect(), which dose not pass auto_delete to kombu.entity.Queue().
On the other hand, Listener uses TopicConsumer.reconnect(), which passes auto_delete. It causes PRECONDITION_FAILED if amqp_auto_delete is True.

Mehdi Abaakouk (sileht)
Changed in oslo.messaging:
status: New → Confirmed
Changed in oslo.messaging:
assignee: nobody → Mehdi Abaakouk (sileht)
status: Confirmed → In Progress
Mehdi Abaakouk (sileht)
Changed in oslo.messaging:
importance: Undecided → Medium
milestone: none → next-kilo
Revision history for this message
Mehdi Abaakouk (sileht) wrote :
Mehdi Abaakouk (sileht)
Changed in oslo.messaging:
milestone: 1.7.0 → next-kilo
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo.messaging (master)

Reviewed: https://review.openstack.org/138723
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=0359147713c4a1e4b77fce60ad45c367f70f0059
Submitter: Jenkins
Branch: master

commit 0359147713c4a1e4b77fce60ad45c367f70f0059
Author: Mehdi Abaakouk <email address hidden>
Date: Wed Dec 3 14:35:04 2014 +0100

    NotifyPublisher need handle amqp_auto_delete

    Notifypublisher and TopicConsumer must create the exchange and the
    queue with the same parameters otherwise kombu raises a
    'PreconditionFailed' error. But when cfg.CONF.amqp_auto_delete = True,
    this is not the case. This change ensures that amqp_auto_delete
    correclty set when cfg.CONF.amqp_auto_delete = True.

    Closes bug: #1366597

    Change-Id: I8c661deae82bcf2ae2e114621e69e0c7ae2a0a69

Changed in oslo.messaging:
status: In Progress → Fix Committed
Changed in oslo.messaging:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.