Glance tests failing, breaking Cinder check jobs

[Rushi Agrawal]

Two glance tests are failing right now. Log:
http://paste.openstack.org/show/107812/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/119645

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/119647

[Huang Zhiteng (zhiteng-huang)]

So it seems like this bug is caused by recent glanceclient change?

[Andrew Kerr (andrew-kerr)]

Yes. Glance changed their client's __init__ implementation, which the cinder tests were stubbing parts of, so the tests starting failing because the new method calls in the __init__ were not stubbed out.

As mentioned in the commit message for the fix, the cinder test improperly knew too much about glance's implementation, and was actually testing the glance client's __init__ functionality, rather than making sure that cinder sent the correct version request.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/119645
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=04abab869d28e007d9b869122740f70cd839daf7
Submitter: Jenkins
Branch: master

commit 04abab869d28e007d9b869122740f70cd839daf7
Author: Rushi Agrawal <email address hidden>
Date: Mon Sep 8 00:28:57 2014 +0530

    Mock glance client object in version unit tests

    This patch changes the glance client version unit tests
    to mock the Client object completely. Previously the
    tests were ensuring the right version of the client was
    returned, but that required too much knowledge of glance's
    implementation and ended up breaking the tests when glance
    changed the implementation details of the Client class.

    The new code tests if cinder is calling the integration
    point correctly for the version, rather than if glance
    is correctly returning the right client; that should be
    a glance test, not a cinder test.

    Closes-Bug: 1366596
    Change-Id: I979175e6c3b5f98076bde6d36ca52fb8b03009b8

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/119647
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=5863f52a9f140cfd13e1794ebf6db434517802b3
Submitter: Jenkins
Branch: stable/icehouse

commit 5863f52a9f140cfd13e1794ebf6db434517802b3
Author: Rushi Agrawal <email address hidden>
Date: Mon Sep 8 00:28:57 2014 +0530

    Mock glance client object in version unit tests

    This patch changes the glance client version unit tests
    to mock the Client object completely. Previously the
    tests were ensuring the right version of the client was
    returned, but that required too much knowledge of glance's
    implementation and ended up breaking the tests when glance
    changed the implementation details of the Client class.

    The new code tests if cinder is calling the integration
    point correctly for the version, rather than if glance
    is correctly returning the right client; that should be
    a glance test, not a cinder test.

    Closes-Bug: 1366596
    Change-Id: I979175e6c3b5f98076bde6d36ca52fb8b03009b8
    (cherry-picked from 04abab869d28e007d9b869122740f70cd839daf7)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/119801

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/119801
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=afa5c5122578fc02c158125ced5e51d25eb10209
Submitter: Jenkins
Branch: stable/havana

commit afa5c5122578fc02c158125ced5e51d25eb10209
Author: Jay S. Bryant <email address hidden>
Date: Mon Sep 8 11:09:12 2014 -0500

    Mock glance client object in version unit tests

    This patch changes the glance client version unit tests
    to mock the Client object completely. Previously the
    tests were ensuring the right version of the client was
    returned, but that required too much knowledge of glance's
    implementation and ended up breaking the tests when glance
    changed the implementation details of the Client class.

    The new code tests if cinder is calling the integration
    point correctly for the version, rather than if glance
    is correctly returning the right client; that should be
    a glance test, not a cinder test.

    Closes-Bug: 1366596
    (cherry-picked from 04abab869d28e007d9b869122740f70cd839daf7)
    (cherry picked from commit 5863f52a9f140cfd13e1794ebf6db434517802b3)

    Conflicts:

     cinder/tests/image/test_glance.py

    Change-Id: I979175e6c3b5f98076bde6d36ca52fb8b03009b8