libvirt: spawning an instance may have an additional 4 db writes

Bug #1366548 reported by Gary Kotton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Gary Kotton

Bug Description

instance save is used by the driver when it does not need to be. each instance save will invoke a db access. after the spawn method is called the instance is updated so there is no need for the save

Tags: libvirt
Gary Kotton (garyk)
Changed in nova:
importance: Undecided → High
Gary Kotton (garyk)
tags: added: libvirt
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/119622

Changed in nova:
assignee: nobody → Gary Kotton (garyk)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/119622
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=bc40e85c0278afcca74892fc818da1e005f13fc7
Submitter: Jenkins
Branch: master

commit bc40e85c0278afcca74892fc818da1e005f13fc7
Author: Gary Kotton <email address hidden>
Date: Sun Sep 7 07:25:31 2014 -0700

    libvirt: Unnecessary instance.save(s) called

    When spawning an instance there may a considerable amount of
    instance.save() called. This is not necessary as the compute
    manager will update the instance after the spawn method has
    successfully completed.

    Change-Id: I61610b3869caeb7822eab3f2d09335744b75db28
    Closes-bug: #1366548

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → juno-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-rc1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.