Cinderclient metadata CLI output inconsistent

[Rushi Agrawal]

As can be seen here: http://paste.openstack.org/show/107095/

'cinder metadata-update-all' returns metadata as a dict of 'u' prefixed strings
'cinder metadata <vol> set' returns nothing
'cinder metadata-show' returns keys and values in a separate column

[John Griffith (john-griffith)]

Would be nice if it were all consistent with 'cinder metadata-update-all'.

[Duncan Thomas (duncan-thomas)]

r@ra:~$ cinder metadata-update-all 4138828a-2f03-48c1-9dec-49ccaaabe2d6 key=val key2=val2
+----------+------------------------------------+
| Property | Value |
+----------+------------------------------------+
| metadata | {u'key2': u'val2', u'key': u'val'} |
+----------+------------------------------------+
r@ra:~$ cinder metadata-show 4138828a-2f03-48c1-9dec-49ccaaabe2d6
+-------------------+-------+
| Metadata-property | Value |
+-------------------+-------+
| key | val |
| key2 | val2 |
+-------------------+-------+

So given a CLI (i.e. a human readable output), you want the thing that is hard to read and has python specific notation? I think the two column output makes far more sense.

[Thang Pham (thang-pham)]

I made it consistent with "cinder metadata-show", where each property has its own table row. The patch is up at https://review.openstack.org/#/c/119882/.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/119882
Committed: https://git.openstack.org/cgit/openstack/python-cinderclient/commit/?id=fdba364b7d64ee6a67174485d215ae8f30ccbc49
Submitter: Jenkins
Branch: master

commit fdba364b7d64ee6a67174485d215ae8f30ccbc49
Author: Thang Pham <email address hidden>
Date: Mon Sep 8 15:13:30 2014 -0400

    Make cinderclient metadata CLI output consistent

    cinder metadata-update-all and metadata-show produces
    inconsistent output. The following patch makes the output of each
    command above consistent, where each metadata property will
    be printed on a separate table row.

    Change-Id: I42933bc6c0e4f925c19cfd4db6d1a205de06a73d
    Closes-Bug: #1366289