DHCP scan using cluster interface name as network interface?
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MAAS |
Fix Released
|
Critical
|
Jeroen T. Vermeulen |
Bug Description
I'm working on IPv6 handling. A package built from fresh trunk gives me errors like:
Sep 5 13:33:24 maasboss maas.dhcp.detect: [ERROR] Ignoring DHCP scan for ipv6, it no longer exists. Check your cluster interfaces configuration.
My MAAS does have a cluster interface whose name is “ipv6” — but its *network* interface is “eth1”. The error comes from probe_interface, which is not exported, so you'd expect the caller to be within the module; but the only call there definitely uses the cluster interface's network interface, not its name.
However dhcp_probe_service now also calls probe_interface, and it passes the wrong value: it should pass interface[
So two things to fix:
1. Export probe_dhcp in __all__ (we ought to enforce this, or stop doing it, really).
2. Pass interface[
Related branches
- Graham Binns (community): Approve
-
Diff: 245 lines (+98/-24)7 files modifiedsrc/maasserver/rpc/nodegroupinterface.py (+13/-3)
src/maasserver/rpc/tests/test_nodegroupinterface.py (+53/-0)
src/maasserver/rpc/tests/test_regionservice.py (+5/-1)
src/provisioningserver/dhcp/detect.py (+3/-1)
src/provisioningserver/pserv_services/dhcp_probe_service.py (+2/-2)
src/provisioningserver/pserv_services/tests/test_dhcp_probe_service.py (+21/-17)
src/provisioningserver/rpc/region.py (+1/-0)
Changed in maas: | |
status: | Triaged → Fix Committed |
Changed in maas: | |
status: | Fix Committed → Fix Released |