Fix bad performance when editing project

Bug #1365685 reported by Doug Fish
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Doug Fish

Bug Description

Closely related to bug #1278920. Basically the same problem occurs in the Edit Project action. (UpdateProject.handle). There is an API call to get the role for each user, which doesn't scale. The same keystone client addition from #1278920 (get_project_users_roles) can be used here as well.

Doug Fish (drfish)
Changed in horizon:
assignee: nobody → Doug Fish (drfish)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/119487

Changed in horizon:
status: New → In Progress
Doug Fish (drfish)
Changed in horizon:
milestone: none → juno-rc1
importance: Undecided → Medium
David Lyle (david-lyle)
Changed in horizon:
milestone: juno-rc1 → kilo-1
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-1 → kilo-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by David Lyle (<email address hidden>) on branch: master
Review: https://review.openstack.org/119487
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-2 → kilo-3
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-3 → kilo-rc1
David Lyle (david-lyle)
Changed in horizon:
milestone: kilo-rc1 → next
Doug Fish (drfish)
tags: added: kilo-rc-potential
Changed in horizon:
milestone: next → kilo-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/119487
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=dad9791640ddebff9634b1dffb774d173921ac78
Submitter: Jenkins
Branch: master

commit dad9791640ddebff9634b1dffb774d173921ac78
Author: Doug Fish <email address hidden>
Date: Tue Mar 17 12:29:16 2015 -0500

    Fix bad performance on project update panel

    Modify the Edit Project action use get_project_user_roles API
    instead of making a separate call for each user.

    The get_project_user_roles API which enables this improvement
    is new in Keystone V3. Improved performance will be seen only
    when using Keystone V3.

    Change-Id: I204f25800abcbc35a130d351431c938b01c72d18
    Closes-bug: #1365685

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-rc1 → 2015.1.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to horizon (master)

Reviewed: https://review.openstack.org/177005
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=1ccc4dd14adfe85946ff87529db144330cac53ae
Submitter: Jenkins
Branch: master

commit 1ccc4dd14adfe85946ff87529db144330cac53ae
Author: Jingjing Ren <email address hidden>
Date: Mon Apr 20 01:16:05 2015 +0000

    Fix bad performance when editing domain members

    Modify the Edit action use get_domain_user_roles API
    instead of making a separate call for each user.

    Change-Id: I9a37cf0d74b8a5ef6e1a6d4013a2b6826649f0c2
    Related-Bug: #1365685
    Closes-Bug: #1445249

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.