API error message reports incorrect state for unavailable soft reboot

[Mathew Odden]

Sending a soft reboot request to the Nova API while an instance is in the stopped state results in the following response:

Status
409 Conflict

{
conflictingRequest: {
message: "Cannot 'reboot' while instance is in vm_state stopped"
code: 409
}
-
}

Since we support a hard reboot on certain states it would be better to indicate the type of reboot in the error message that isn't supported. e.g. return message: "Cannot 'soft reboot' while instance is in vm_state stopped"

[Mathew Odden (locke105)]

Looks like its a small string modification here http://git.openstack.org/cgit/openstack/nova/tree/nova/compute/api.py#n2078

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/119254
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=45fe3b071f56afbc9ac7d280acd68f7c976904bb
Submitter: Jenkins
Branch: master

commit 45fe3b071f56afbc9ac7d280acd68f7c976904bb
Author: Matt Odden <email address hidden>
Date: Thu Sep 4 23:31:54 2014 +0000

    Update invalid state error message on reboot API

    This change adds more detail to the error message
    when a request to soft reboot an instance in an
    invalid state fails, indicating that specifically
    soft reboot is the request that failed, when
    a hard reboot might still succeed.

    Closes-Bug: 1365683

    Change-Id: I4b12aa261d1c4fa05bacd5311793ed6e0478e59b