Found patrons with same name not opening

[Terran McCanna]

When registering a new patron, the 'Found xx patrons with same name' and 'Found xx patrons with same address' are displaying on the Register Patron screen, but clicking on them does not respond.

JavaScript Console gives error: ReferenceError:js2JSON is not defined

And points to the following bit of code:

               function spawn_search(s) {
                        xulG.new_patron_tab( {}, { 'doit' : 1, 'query' : js2JSON(s) } );
                }

Tested on:
Evergreen 2.5.1 (PINES production) and Evergreen 2.6.2 (branch created from master on 8/26/2014)

This bug may be related to https://bugs.launchpad.net/evergreen/+bug/1243853

[Erica Rohlfs (erohlfs)]

Hi Terran!

Is this error occurring while you are completing the registration of a patron who self-registered? I just tested this on a training staff client on version 2.6.2 and could not recreate the error. However, I tested it by registering a new patron who did not first self-register.

[Erica Rohlfs (erohlfs)]

I just tested this by registering a Pending Patron and it does return the error described.

[Terran McCanna (tmccanna)]

Hi Erica,

Thanks for testing.

We are seeing this error when creating a new patron who has not self-registered.

We are seeing a different error (see my comment appended to https://bugs.launchpad.net/evergreen/+bug/1243853) when creating a patron who has self-registered.

When we edit a patron that has already been saved (regardless of whether they had originally self-registered or not) and click on that link, it works properly.

[Adam Bowling (abowling)]

I just pushed a patch for this on bug #1243853. The index.xhtml file in .../xul/../server was missing a reference to the "JSON_v1.js" script. Adding that script reference solved this issue in the test environment. That should resolve all the other issues related, presuming there aren't other script errors.

[Terran McCanna (tmccanna)]

I have tested this code and consent to signing off on it with my name, Terran McCanna and email address, <email address hidden>.

Adam Bowling's code:
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=84300dde4230e0f78f67f1bdf91c7158d7831dc3

(The code fixes this bug, but does not fix the related bug #1243853.)

[Jason Stephenson (jstephenson)]

I confirmed this one in 2.7 and master, so assume it applies to 2.8 as well.

I tested Adam's commit and it works for me.

I picked this commit into master, rel_2_7, and rel_2_8, and altered the commit message to add Terran's sign off as well as my own. I added an explanation of how to reproduce the bug and the expected behavior after applying the fix. Finally, I altered the first commit message line to have this LP bug # and description.

Thanks, everyone!