metadata agent does not cache auth info

Bug #1365352 reported by Chengli Xu
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Chengli Xu
Icehouse
Fix Released
High
Chengli Xu

Bug Description

metadata agent had tried to cache auth info by the means of "self.auth_info = qclient.get_auth_info()" in _get_instance_and_tenant_id(), however this qclient is not the exact one which would be used in inner methods, In short, metadata agent does not implement auth info caching correctly but still retrieves new token from keystone every time.

Tags: l3-ipam-dhcp
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/118996

Changed in neutron:
assignee: nobody → Chengli Xu (superekcah)
status: New → In Progress
Akihiro Motoki (amotoki)
Changed in neutron:
milestone: none → juno-rc1
importance: Undecided → High
tags: added: icehouse-backport-potential l3-ipam-dhcp
Revision history for this message
Akihiro Motoki (amotoki) wrote :

Precisely speaking, it is a degrade caused by commit 3faea81c6029033c85cefd6e98d7a3e719e858f5.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/118996
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=3c503adcf703db7b772208389b43ee09cee66185
Submitter: Jenkins
Branch: master

commit 3c503adcf703db7b772208389b43ee09cee66185
Author: Chengli XU <email address hidden>
Date: Wed Sep 3 14:52:34 2014 +0800

    Fix metadata agent's auth info caching

    metadata agent does not implement auth info cache correctly but
    retrieves from keystone every time

    Change-Id: Ifc1f580185d7600b48aaf80d112fc80e0c4253f2
    Closes-bug: #1365352

Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/120418

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/icehouse)

Reviewed: https://review.openstack.org/120418
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=97d622a13b67679392c596ccec9a8f0987ce865e
Submitter: Jenkins
Branch: stable/icehouse

commit 97d622a13b67679392c596ccec9a8f0987ce865e
Author: Chengli XU <email address hidden>
Date: Wed Sep 3 14:52:34 2014 +0800

    Fix metadata agent's auth info caching

    metadata agent does not implement auth info cache correctly but
    retrieves from keystone every time

    Cherry-pick from https://review.openstack.org/#/c/118996/

    Conflicts:
     neutron/agent/metadata/agent.py
     neutron/tests/unit/test_metadata_agent.py

    Change-Id: Ifc1f580185d7600b48aaf80d112fc80e0c4253f2
    Closes-bug: #1365352

tags: added: in-stable-icehouse
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Alan Pevec (apevec)
tags: removed: icehouse-backport-potential in-stable-icehouse
Thierry Carrez (ttx)
Changed in neutron:
milestone: juno-rc1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.