Rename cli variable in ironic driver

Bug #1365228 reported by Michael Davies
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Kamil Rykowski

Bug Description

In nova/virt/ironic/driver.py there is the IronicDriver class. It abbreviates references to the ironicclient as 'icli'. This should be unabbreviated to make the code clearer.

This came up as part of https://review.openstack.org/#/c/111425/19/nova/virt/ironic/driver.py

tags: added: low-hanging-fruit
Changed in nova:
status: New → Confirmed
importance: Undecided → Low
Changed in nova:
assignee: nobody → Kamil Rykowski (kamil-rykowski)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/120439

aeva black (tenbrae)
tags: added: ironic
Revision history for this message
Kamil Rykowski (kamil-rykowski) wrote :

Changes has been rebased. Feel free to review. Thanks.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/120439
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=0260844e20ce39af34caad0cd4df5bb7338af38c
Submitter: Jenkins
Branch: master

commit 0260844e20ce39af34caad0cd4df5bb7338af38c
Author: Kamil Rykowski <email address hidden>
Date: Wed Sep 10 15:25:58 2014 +0200

    Rename cli variable in ironic driver

    Code in ironic driver used "icli" as variable name to reference to
    ironic client instance. It has been renamed to "ironicclient" to make
    the code clearer.

    Change-Id: Ic9e314e882f5e5e305a5ea84f7c2f102f91140dd
    Closes-Bug: #1365228

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → kilo-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.