neutron

Spelling mistakes in the comments

Bug #1365088 reported by Rishabh on 2014-09-03

This bug report is a duplicate of: Bug #1390035: Neutron-wide-spelling. Edit Remove

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	neutron	Fix Committed	Wishlist	Raildo Mascena de Sousa Filho

Bug Description

Spelling mistake in comment in neutron/neutron/agent/l2population_rpc.py

Tags:

Rishabh (rishabja) on 2014-09-03

Changed in neutron:
assignee:	nobody → Rishabh (rishabja)

Revision history for this message

Eugene Nikanorov (enikanorov) wrote on 2014-09-28:

You may want to put either a reference to a line number (on github) or already upload a patch.

Changed in neutron:
importance:	Undecided → Low
tags:	added: low-hanging-fruit
Changed in neutron:
status:	New → Incomplete

Revision history for this message

mfabros (melissa-fabros) wrote on 2014-10-08:

I took a look at the comments but couldn't find the typo listed in the bug notice. I did commit changes to the comment to help aid the comment sections' clarity. I agree with enikanorov that a line number reference would be helpful in fixing the bug.

Revision history for this message

David Mahony (david-mahony) wrote on 2014-10-14:

grammar? https://github.com/openstack/neutron/blob/master/neutron/agent/l2population_rpc.py#L69

Revision history for this message

Jerome Bertolino (jebertol) wrote on 2014-10-14:

Agree with line 69, and I also see the following typos/grammar issues:

https://github.com/openstack/neutron/blob/master/neutron/agent/l2population_rpc.py#L79
“respond" should be "response"

https://github.com/openstack/neutron/blob/master/neutron/agent/l2population_rpc.py#L154
“infomation" should be “information"

https://github.com/openstack/neutron/blob/master/neutron/agent/l2population_rpc.py#L221
"informations" should be "information"

Revision history for this message

mfabros (melissa-fabros) wrote on 2014-10-15:

Thank you david-mahony and jebertol for your notes. I updated changes you noted and tried to smooth out the English usage in the comments

Eugene Nikanorov (enikanorov) on 2014-10-15

Changed in neutron:
importance:	Low → Wishlist

Chris Grivas (chgri) on 2014-10-29

Changed in neutron:
status:	Incomplete → Confirmed

Raildo Mascena de Sousa Filho (raildo) on 2014-11-03

Changed in neutron:
assignee:	Rishabh (rishabja) → Raildo Mascena de Sousa Filho (raildo)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-11-03: Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/132563

Changed in neutron:
status:	Confirmed → In Progress

Revision history for this message

Edgar Magana (emagana) wrote on 2014-11-06:

There are always spelling mistakes in OpenStack code. I would prefer to have this fix close to Kilo-3 collecting all of them. Let's open a new bug that will cover all Neutron.

Revision history for this message

David Mahony (david-mahony) wrote on 2014-11-06:

I would like to contribute to this Neutron wide bug.

Revision history for this message

David Mahony (david-mahony) wrote on 2014-11-06:

Opened: https://bugs.launchpad.net/neutron/+bug/1390035

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-11-13: Fix merged to neutron (master)

#10

Reviewed: https://review.openstack.org/132563
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=3476cf54c950a227ee9778af743e39e27cfbf534
Submitter: Jenkins
Branch: master

commit 3476cf54c950a227ee9778af743e39e27cfbf534
Author: Raildo Mascena <email address hidden>
Date: Mon Nov 3 11:04:23 2014 -0300

Resolving some spelling mistakes