VMware driver doesn't return typed console

Bug #1364849 reported by Matthew Booth
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Gary Kotton

Bug Description

Change I8f6a857b88659ee30b4aa1a25ac52d7e01156a68 added typed consoles, and updated drivers to use them. However, when it touched the VMware driver, it modified get_vnc_console in VMwareVMOps, but not in VMwareVCVMOps, which is the one which is actually used.

Incidentally, VMwareVMOps has now been removed, so this type of confusion should not happen again.

Tags: vmware
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/118579

Changed in nova:
assignee: nobody → Matthew Booth (mbooth-9)
status: New → In Progress
Changed in nova:
importance: Undecided → High
tags: added: vmware
Changed in nova:
assignee: Matthew Booth (mbooth-9) → Gary Kotton (garyk)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/118579
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=c4d0e55098952ad3180f74357a9256da43bf7d15
Submitter: Jenkins
Branch: master

commit c4d0e55098952ad3180f74357a9256da43bf7d15
Author: Matthew Booth <email address hidden>
Date: Wed Sep 3 10:21:51 2014 +0100

    VMware: Fix return type of get_vnc_console()

    Change I8f6a857b88659ee30b4aa1a25ac52d7e01156a68 changed the return type of
    get_vnc_console(), but didn't update it in VMwareVCVMOps.

    Closes-Bug: #1364849
    Change-Id: I25edf0a19fa79439ed375ad128d0050718d04cb3

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → juno-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-rc1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.