Big Switch: Request context is missing from backend requests

Bug #1364696 reported by Kevin Benton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Kevin Benton
Icehouse
Fix Released
Low
Kevin Benton

Bug Description

The request context that comes into Neutron is not included in the request to the backend. This makes it difficult to correlate events in the debug logs on the backend such as what incoming Neutron request resulted in particular REST calls to the backend and if admin privileges were used.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/118514

Changed in neutron:
assignee: nobody → Kevin Benton (kevinbenton)
status: New → In Progress
Kyle Mestery (mestery)
Changed in neutron:
milestone: none → juno-rc1
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/118514
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=50c65d16bee8e6e46840f232519e92d9ba9989b4
Submitter: Jenkins
Branch: master

commit 50c65d16bee8e6e46840f232519e92d9ba9989b4
Author: Kevin Benton <email address hidden>
Date: Tue Sep 2 11:27:51 2014 -0700

    BSN: Add context to backend request for debugging

    Include the request context with calls to the backend
    Big Switch controllers to assist with event correlation
    and debugging object provenance. The auth token is
    stripped since this information is sensitive and
    these requests will appear in debug logs.

    This also removes mutable objects from default arguments
    in some of the server manager function definitions that
    were interferring with the new use of the headers dict.

    Closes-Bug: #1364696
    Change-Id: I5b80b1596cc145742457b3603cbcd67f6e0d9f36

Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/121733

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/icehouse)

Reviewed: https://review.openstack.org/121733
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=00615335f0edb2c124806f6a53427f17eb5feb42
Submitter: Jenkins
Branch: stable/icehouse

commit 00615335f0edb2c124806f6a53427f17eb5feb42
Author: Kevin Benton <email address hidden>
Date: Tue Sep 2 11:27:51 2014 -0700

    BSN: Add context to backend request for debugging

    Include the request context with calls to the backend
    Big Switch controllers to assist with event correlation
    and debugging object provenance.

    This also removes mutable objects from default arguments
    in some of the server manager function definitions that
    were interferring with the new use of the headers dict.

    Note: The commit to master stripped out an auth_token
    field, however that logic is removed because Icehouse
    did not have the auth_token to begin with.

    Conflicts:
     neutron/plugins/bigswitch/servermanager.py
     neutron/tests/unit/bigswitch/test_servermanager.py
     neutron/tests/unit/ml2/drivers/test_bigswitch_mech.py

    Closes-Bug: #1364696
    Change-Id: I5b80b1596cc145742457b3603cbcd67f6e0d9f36
    (cherry picked from commit 50c65d16bee8e6e46840f232519e92d9ba9989b4)

tags: added: in-stable-icehouse
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: juno-rc1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.