[dashboard] using .push causes python-ibm-db-django to pollute the node attribute

[Mark Vanderwiel]

With this commit:

https://github.rtp.raleigh.ibm.com/core-chef-cookbooks/cookbook-openstack-dashboard/commit/843b3dfaa927aaed0622e0fcdb10a70f661f8ff4

the code in dashboard default attributes is doing the following:

default['openstack']['db']['python_packages']['db2'].push 'python-ibm-db-django'

That package attribute is being used as a common place to hold the list of packages to install for python database support.
By doing this push at the attribute level, it's polluting the common python database package list with dashboard specific packages. This will cause that package to be installed regardless of the intention of using the dashboard recipes.

This should be moved into a dashboard specific db python package attribute that can be overridden just like before, and be used within the dashboard recipes.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/118425

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/118425
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-dashboard/commit/?id=0a2cf2e414f7ee91cda844426ad7cc951da54d1e
Submitter: Jenkins
Branch: master

commit 0a2cf2e414f7ee91cda844426ad7cc951da54d1e
Author: Mark Vanderwiel <email address hidden>
Date: Tue Sep 2 12:42:09 2014 -0500

    Fix .push python-ibm-db-django polluting common attribute

    A Common attribute was having a dashboard specific package added to it.
    This has side effects as it will effect other cookbooks using that attribute.

    * Create attrbute to hold dashboard specific database packages
    * Tests unchanged as they are still correct outcome

    Change-Id: I9dae9dfc7a118203a80492160514cbf7d0f975e9
    Closes-Bug: #1364508

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/132491

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/132491
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-dashboard/commit/?id=1c13d6fa1a77923dbc748dd24f4d25a849b97def
Submitter: Jenkins
Branch: stable/icehouse

commit 1c13d6fa1a77923dbc748dd24f4d25a849b97def
Author: Yi Ming Yin <email address hidden>
Date: Mon Nov 3 09:35:54 2014 +0800

    Fix .push python-ibm-db-django polluting common attribute

    A Common attribute was having a dashboard specific package added to it.
    This has side effects as it will effect other cookbooks using that
    attribute.

    * Create attrbute to hold dashboard specific database packages
    * Tests unchanged as they are still correct outcome

    Change-Id: I99768ae91ed0db9f632d2529014130c38096f8fe
    Closes-Bug: #1364508

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cookbook-openstack-dashboard ocata-eol release.