Puppet services have not hasrestart options

Bug #1364119 reported by Dmitry Ilyin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Dmitry Ilyin

Bug Description

Many services in Puppet have not hasrerstart options and are manages using stop and start instead of restart.
Many init scripts are written in a way that they dont's actually stop the running service if stop is called and pid file is not correct.
Using restart will always stop and start these services.

Dmitry Ilyin (idv1985)
Changed in fuel:
importance: Undecided → High
milestone: none → 5.1
assignee: nobody → Dmitry Ilyin (idv1985)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/118201

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (stable/5.0)

Fix proposed to branch: stable/5.0
Review: https://review.openstack.org/118335

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/118201
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=b5d525175b6b54eda8d9dde6d7eb7880421c6349
Submitter: Jenkins
Branch: master

commit b5d525175b6b54eda8d9dde6d7eb7880421c6349
Author: Dmitry Ilyin <email address hidden>
Date: Mon Sep 1 22:23:06 2014 +0400

    Add hasrestart to some services

    Hasrestart makes Puppet use restart instead of stop
    and start to manage a service and many init scripts
    would work better if used like this.

    Change-Id: I9e8e86a1c5bf4bcac9683542e9cfb7ca3100c9e8
    Closes-Bug: 1364119

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (stable/5.0)

Reviewed: https://review.openstack.org/118335
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=af800749b7628f902afb5905fdfbdd9bccd78a94
Submitter: Jenkins
Branch: stable/5.0

commit af800749b7628f902afb5905fdfbdd9bccd78a94
Author: Dmitry Ilyin <email address hidden>
Date: Tue Sep 2 17:27:48 2014 +0400

    Add hasrestart to some services

    (5.0.X backport)
    Hasrestart makes Puppet use restart instead of stop
    and start to manage a service and many init scripts
    would work better if used like this.

    Change-Id: I7cee7cc4690b13d896775124ad00ebeba7daf68e
    Closes-Bug: 1364119

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.