[astute] Post-deployment no-quorum-policy may not be updated

[Vladimir Kuklin]

Astute.log of one of the environments:

2014-08-29T13:52:08 debug: [430] 3755a23e-8686-4bc6-864e-91d4f5d9c804: cmd: /usr/sbin/crm configure property no-quorum-policy=stop
                                               stdout:
                                               stderr: Call cib_apply_diff failed (-206): Application of an update diff failed
ERROR: could not patch cib (rc=206)
INFO: offending xml diff: <diff crm_feature_set="3.0.7">
  <diff-removed>
    <cib epoch="102">
      <configuration>
        <crm_config>
          <cluster_property_set id="cib-bootstrap-options">
            <nvpair value="ignore" id="cib-bootstrap-options-no-quorum-policy"/>
          </cluster_property_set>
        </crm_config>
      </configuration>
    </cib>
  </diff-removed>
  <diff-added>
    <cib epoch="103" num_updates="5" admin_epoch="0" validate-with="pacemaker-1.2" crm_feature_set="3.0.7" have-quorum="1" dc-uuid="node-1" cib-last-written="Fri Aug 29 12:51:30 2014" update-origin="node-3" update-client="crmd">
      <configuration>
        <crm_config>
          <cluster_property_set id="cib-bootstrap-options">
            <nvpair name="no-quorum-policy" value="stop" id="cib-bootstrap-options-no-quorum-policy"/>
          </cluster_property_set>
        </crm_config>
      </configuration>
    </cib>
  </diff-added>
</diff>
exit code: 0

We need to use cibadmin -P instead of crm to avoid such problems as it can lead to cluster in unconfigured state and to following problems with cluster scalability and failover.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/118164

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/118164
Committed: https://git.openstack.org/cgit/stackforge/fuel-astute/commit/?id=8cc2c5b29d75ec2f60787e225564426a0508b3e4
Submitter: Jenkins
Branch: master

commit 8cc2c5b29d75ec2f60787e225564426a0508b3e4
Author: Vladimir Kuklin <email address hidden>
Date: Mon Sep 1 17:37:05 2014 +0400

    Set no-quorum-policy using cibadmin patch

    Pacemaker crmsh utility may sometimes fail
    when trying to set no-quorum policy as
    xml-diff becomes outdated.

    This approach uses cibadmin patch option
    that applies xml diff cleanly.

    Change-Id: I63297d33ab20c7dd48ffa5064a981d6555c6b502
    Closes-bug: #1363908