New effects don't work on krillin

Bug #1363414 reported by Alan Pope 🍺🐧🐱 πŸ¦„
20
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Ubuntu Terminal App
Fix Released
High
Filippo Scognamiglio

Bug Description

I just received a new device and updated terminal. The default settings result in a purple/pink screen rather than the expected cool old term effects.

Switching off the visual effects results in a normal terminal (pre cool effects).

Works fine on mako.

Related branches

Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :
Download full text (3.4 KiB)

Here's the terminal log..

Trying to load QML from: "/opt/click.ubuntu.com/com.ubuntu.terminal/0.5.128/lib/arm-linux-gnueabihf/bin/qml/ubuntu-terminal-app.qml"
Trying to load QML from: "/opt/click.ubuntu.com/com.ubuntu.terminal/0.5.128/qml/ubuntu-terminal-app.qml"
using main qml file from: "/opt/click.ubuntu.com/com.ubuntu.terminal/0.5.128/qml/ubuntu-terminal-app.qml"
loadAllColorSchemes
qml: kbScrl.height = 111
qml: kbCtrl.height = 52
qml: Column.height = -118
qml: Column.height = 0
qml: Column.height = 975
file:///opt/click.ubuntu.com/com.ubuntu.terminal/0.5.128/qml/ubuntu-terminal-app.qml:25:9: QML Page11: Binding loop detected for property "height"
qml: Column.height = 857
UbuntuWindow - regular geometry
qml: Column.height = 842
file:///opt/click.ubuntu.com/com.ubuntu.terminal/0.5.128/qml/Terminal.qml:172:9: QML Row: Cannot specify left, right, horizontalCenter, fill or centerIn anchors for items inside Row. Row will not function.
qml: kbFn.height = 52
qml: kbFn.height = 111
QOpenGLShader::compile(Fragment): 1:10: S0032: no default precision defined for return value
*** Problematic Fragment shader source code ***
#ifndef GL_FRAGMENT_PRECISION_HIGH
#define highp mediump
#endif

        uniform sampler2D source;
        uniform highp float qt_Opacity;
        uniform highp float time;
        varying highp vec2 qt_TexCoord0;
        varying highp float brightness;

        uniform highp vec4 screen_color;
            uniform highp sampler2D bloomSource;
            uniform highp float screen_curvature;float rgb2grey(vec3 v){
            return dot(v, vec3(0.21, 0.72, 0.04));
        }vec3 computeColor(vec3 color){
            return mix(rgb2grey(color) * screen_color.rgb, color, 0.20000000);
        }void main() {vec2 cc = vec2(0.5) - qt_TexCoord0;float distance = length(cc);
                float distortion = dot(cc, cc) * screen_curvature;
                vec2 coords = (qt_TexCoord0 - cc * (1.0 + distortion) * distortion);vec3 color = computeColor(texture2D(source, coords).rgb);
                vec4 bloomColor = texture2D(bloomSource, coords);
                color += computeColor(bloomColor.rgb) * bloomColor.a * 1.12000000;gl_FragColor = vec4(color * brightness *1.25000000, qt_Opacity);
        }
***
QQuickCustomMaterialShader: Shader compilation failed:
"1:10: S0032: no default precision defined for return value"
UbuntuWindow::handleSurfaceFocusChange(focused=true)
UbuntuWindow::handleSurfaceResize(width=540, height=921)
qml: *** Fragment shader ***
1:10: S0032: no default precision defined for return value
qml: Column.height = 803
file:///opt/click.ubuntu.com/com.ubuntu.terminal/0.5.128/qml/Terminal.qml:172:9: QML Row: Cannot specify left, right, horizontalCenter, fill or centerIn anchors for items inside Row. Row will not function.
file:///opt/click.ubuntu.com/com.ubuntu.terminal/0.5.128/qml/Terminal.qml:172:9: QML Row: Cannot specify left, right, horizontalCenter, fill or centerIn anchors for items inside Row. Row will not function.
file:///opt/click.ubuntu.com/com.ubuntu.terminal/0.5.128/qml/Terminal.qml:271: TypeError: Type error
file:///opt/click.ubuntu.com/com.ubuntu.terminal/0.5.128/qml/Terminal.qml:172:9: QML Row: Cannot specif...

Read more...

description: updated
Revision history for this message
Filippo Scognamiglio (flscogna) wrote :

Ok, some shader compilers are a little bit pedantic. I will take a look at this.

Changed in ubuntu-terminal-app:
assignee: nobody → Filippo Scognamiglio (flscogna)
Changed in ubuntu-terminal-app:
status: New → Confirmed
importance: Undecided → High
Revision history for this message
John McAleely (john.mcaleely) wrote :

The device in question sports a Mali 400 GPU, so I assume it's the mali shader compiler, targetting the Mali 400 series cores:

http://malideveloper.arm.com/develop-for-mali/tools/analysis-debug/mali-gpu-offline-shader-compiler/

(I've not looked closely at that link, but google suggested it to me)

Revision history for this message
Filippo Scognamiglio (flscogna) wrote :

Thank you John, that's really a big help. Now it's late here in italy, but tomorrow I'm going to take a look at that.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

Fix committed into lp:ubuntu-terminal-app at revision 136, scheduled for release in ubuntu-terminal-app, milestone alpha-1

Changed in ubuntu-terminal-app:
status: Confirmed → Fix Committed
Changed in ubuntu-terminal-app:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.