VMware: test_driver_api...test_snapshot_delete_vm_snapshot* need to be fixed

Bug #1363349 reported by Vui Lam
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Vui Lam

Bug Description

once converted to use oslo.vmware,
these test cases, test_driver_api.VMwareAPIVMTestCase.test_snapshot_delete_vm_snapshot* are failing:
http://logs.openstack.org/75/70175/43/check/gate-nova-python27/c714fde/console.html

This is most likely related unintended consequence of mocking time.sleep
These tests are currently proposed to be skipped but we should look to provide an fix for the test cases as soon as possible.

A separate patch was posted to demonstrate the potential cause. See lone diff between patch 1 (which fails the above-mentioned tests) and patch 3 (which doesn't)
https://review.openstack.org/#/c/117897/1..3/nova/tests/virt/vmwareapi/test_driver_api.py

Tags: vmware
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/117944

Changed in nova:
assignee: nobody → Vui Lam (vui)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (master)

Change abandoned by Vui Lam (<email address hidden>) on branch: master
Review: https://review.openstack.org/117944

Changed in nova:
milestone: juno-3 → none
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote :

Following the comments in the review, i believe this was already fixed elsewhere. So marking this as fixed.

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → juno-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-rc1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.