Tox including extraneous files

Bug #1363191 reported by Matt Kassawara
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
openstack-manuals
Fix Released
High
Andreas Jaeger

Bug Description

The 'tox -e checkniceness' command returns a variety of errors regarding possibly extraneous files.

$ tox -e checkniceness
checkniceness runtests: PYTHONHASHSEED='1414915594'
checkniceness runtests: commands[0] | openstack-doc-test --check-niceness

OpenStack Doc Checks (using openstack-doc-tools version 0.18.1)

Testing repository 'openstack-manuals'

Testing patch:
  Title: Improve install guide neutron ML2 sections
  Author: Matthew Kassawara
  Branch: bp/instguideimprovements/neutron1
Checking XML files for niceness...
Check passed, validated 3 XML files.

Run time was: 0.25 seconds.
Congratulations, all tests passed!
checkniceness runtests: commands[1] | doc8 -e .rst -e .txt doc
doc/install-guide/target/docbkx/fonts/CartoGothic-Std/FontSite License.txt:1: D002 Trailing whitespace
doc/install-guide/target/docbkx/fonts/CartoGothic-Std/FontSite License.txt:2: D002 Trailing whitespace
doc/install-guide/target/docbkx/fonts/CartoGothic-Std/FontSite License.txt:3: D002 Trailing whitespace
doc/install-guide/target/docbkx/fonts/CartoGothic-Std/FontSite License.txt:4: D002 Trailing whitespace
doc/install-guide/target/docbkx/fonts/CartoGothic-Std/FontSite License.txt:5: D002 Trailing whitespace
doc/install-guide/target/docbkx/fonts/CartoGothic-Std/FontSite License.txt:6: D002 Trailing whitespace
doc/install-guide/target/docbkx/fonts/CartoGothic-Std/FontSite License.txt:7: D002 Trailing whitespace
doc/install-guide/target/docbkx/fonts/CartoGothic-Std/FontSite License.txt:8: D002 Trailing whitespace
doc/install-guide/target/docbkx/fonts/CartoGothic-Std/FontSite License.txt:9: D002 Trailing whitespace
doc/install-guide/target/docbkx/fonts/CartoGothic-Std/FontSite License.txt:10: D002 Trailing whitespace
doc/install-guide/target/docbkx/fonts/CartoGothic-Std/FontSite License.txt:11: D002 Trailing whitespace
doc/install-guide/target/docbkx/fonts/CartoGothic-Std/FontSite License.txt:12: D002 Trailing whitespace
doc/install-guide/target/docbkx/fonts/CartoGothic-Std/FontSite License.txt:13: D002 Trailing whitespace
doc/install-guide/target/docbkx/fonts/CartoGothic-Std/FontSite License.txt:14: D002 Trailing whitespace
doc/install-guide/target/docbkx/fonts/CartoGothic-Std/FontSite License.txt:15: D002 Trailing whitespace
doc/install-guide/target/docbkx/fonts/CartoGothic-Std/FontSite License.txt:16: D002 Trailing whitespace
doc/install-guide/target/docbkx/fonts/CartoGothic-Std/FontSite License.txt:17: D002 Trailing whitespace
doc/install-guide/target/docbkx/fonts/CartoGothic-Std/FontSite License.txt:18: D002 Trailing whitespace

(output truncated)

Revision history for this message
Andreas Jaeger (jaegerandi) wrote :

note this only happens in a local environment, not in the gate.

Changed in openstack-manuals:
importance: Undecided → High
status: New → Confirmed
Revision history for this message
Andreas Jaeger (jaegerandi) wrote :

Joshua,
doc8 -e .rst -e .txt --ignore-path=doc/install-guide/target/ doc

does not exclude the directory doc/install-guide/target at all ;(

Revision history for this message
Andreas Jaeger (jaegerandi) wrote :

Joshua, I would love to have something like:
doc8 --ignore-path=doc/*/target

to ignore all target directories of doc/X

Revision history for this message
Joshua Harlow (harlowja) wrote :

Ah, hmmm, lets do that in a different change, sound ok?

Revision history for this message
Joshua Harlow (harlowja) wrote :

Actually nm, glob support added :-P

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-manuals (master)

Fix proposed to branch: master
Review: https://review.openstack.org/117986

Changed in openstack-manuals:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-manuals (master)

Reviewed: https://review.openstack.org/117986
Committed: https://git.openstack.org/cgit/openstack/openstack-manuals/commit/?id=f745c2aca3411b41d84d940cdbde1a550a17ec75
Submitter: Jenkins
Branch: master

commit f745c2aca3411b41d84d940cdbde1a550a17ec75
Author: Andreas Jaeger <email address hidden>
Date: Sat Aug 30 19:59:51 2014 +0200

    Use [doc8] section

    Move settings for doc8 into its own section and ignore target
    directories.

    Change-Id: Ic3e6a3ab8136812f06cc4ff2846247a8c8f765d3
    Partial-Bug: #1363191

Revision history for this message
Andreas Jaeger (jaegerandi) wrote :

This should be fixed with current doc8 package, please update your package.

Changed in openstack-manuals:
status: In Progress → Fix Released
Revision history for this message
Matt Kassawara (ionosphere80) wrote :

This is happening again.

Revision history for this message
Andreas Jaeger (jaegerandi) wrote :

I can reproduce ;(

Changed in openstack-manuals:
status: Fix Released → Confirmed
Revision history for this message
Matt Kassawara (ionosphere80) wrote :

Tox seems to work again. Should we close this bug?

Changed in openstack-manuals:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.